You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "uds5501 (via GitHub)" <gi...@apache.org> on 2025/07/02 10:50:26 UTC
[PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
uds5501 opened a new pull request, #18189:
URL: https://github.com/apache/druid/pull/18189
This reverts commit 6b3cb50cdd8fc8c3dd9db2b55351758634c975a5.
### Description
Unblocking issues where cachedNamespace failed to load by brokers.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #18189:
URL: https://github.com/apache/druid/pull/18189#issuecomment-3027464737
This is quite odd, though. The `ObjectMapper` originally used by the `LookupReferencesManager` is the same that the `CoordinatorClientImpl` uses.
I wonder if using a `StringFullResponseHandler` instead of `BytesFullResponseHandler` might help. 🤷🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #18189:
URL: https://github.com/apache/druid/pull/18189#issuecomment-3027399096
@uds5501 , could you please attach the stack trace in the PR description which shows the blocked threads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on PR #18189:
URL: https://github.com/apache/druid/pull/18189#issuecomment-3027816403
Merging this while we find the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #18189:
URL: https://github.com/apache/druid/pull/18189#discussion_r2179790076
##########
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java:
##########
@@ -471,24 +476,37 @@
@Nullable
private Map<String, LookupExtractorFactoryContainer> tryGetLookupListFromCoordinator(String tier)
+ throws IOException, InterruptedException
{
- try {
- return FutureUtils.getUnchecked(coordinatorClient.fetchLookupsForTier(tier), true);
+ final StringFullResponseHolder response = fetchLookupsForTier(tier);
+ if (response.getStatus().equals(HttpResponseStatus.NOT_FOUND)) {
+ LOG.warn("No lookups found for tier [%s], response [%s]", tier, response);
Review Comment:
## Use of default toString()
Default toString(): StringFullResponseHolder inherits toString() from Object, and so is not suitable for printing.
[Show more details](https://github.com/apache/druid/security/code-scanning/2836)
##########
server/src/test/java/org/apache/druid/query/lookup/LookupReferencesManagerTest.java:
##########
@@ -80,29 +81,50 @@
);
container = new LookupExtractorFactoryContainer("v0", lookupExtractorFactory);
mapper.registerSubtypes(MapLookupExtractorFactory.class);
+ String temporaryPath = temporaryFolder.newFolder().getAbsolutePath();
Review Comment:
## Unread local variable
Variable 'String temporaryPath' is never read.
[Show more details](https://github.com/apache/druid/security/code-scanning/2445)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #18189:
URL: https://github.com/apache/druid/pull/18189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Revert "Use CoordinatorClient for fetching tier lookup (#18142)" (druid)
Posted by "uds5501 (via GitHub)" <gi...@apache.org>.
uds5501 commented on PR #18189:
URL: https://github.com/apache/druid/pull/18189#issuecomment-3027405791
@kfaraz added in the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org