You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/19 06:33:16 UTC
[GitHub] [commons-math] anantdahiya8 opened a new pull request, #213: [MATH-1651] fix flaky test in commons-math-neuralnet
anantdahiya8 opened a new pull request, #213:
URL: https://github.com/apache/commons-math/pull/213
`ConcurrentHashMap` does not guarantee the order of elements. Replacing it with `Collections.synchronizedMap` which guarantees the order of the elements.
Test which were failing :
org.apache.commons.math4.neuralnet.NetworkTest#testIterationOrder
org.apache.commons.math4.neuralnet.sofm.KohonenUpdateActionTest#testUpdate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] aherbert commented on pull request #213: [MATH-1651] fix flaky test in commons-math-neuralnet
Posted by GitBox <gi...@apache.org>.
aherbert commented on PR #213:
URL: https://github.com/apache/commons-math/pull/213#issuecomment-1283525473
Changing the implementation should be done after consideration of whether the tests should be changed. In this case the KohonenUpdateActionTest#testUpdate can be altered to use the Neuron identifier to store the distances, e.g.:
```Java
for (Neuron n : net) {
distancesBefore[(int) n.getIdentifier()] = dist.applyAsDouble(n.getFeatures(), features);
}
```
As for the NetworkTest#testIterationOrder, that is imposing a constraint that the collection of Neurons has to be ordered by the identifier. This constraint is not documented in the Neuron class. The test may be too constrictive, preventing use of the optimum implementation in the Network.
Can you post this issue to the developer mailing list (dev@commons.apache.org) with the subject '[Math] neuralnet <details>' . It may be the best solution is to remove the testIterationOrder test, rather than change the Network implementation, and document the behaviour as having an unspecified iteration order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] anantdahiya8 commented on pull request #213: [MATH-1651] fix flaky test in commons-math-neuralnet
Posted by GitBox <gi...@apache.org>.
anantdahiya8 commented on PR #213:
URL: https://github.com/apache/commons-math/pull/213#issuecomment-1301671318
@aherbert I have updated the code and sent a mail for removing this flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] codecov-commenter commented on pull request #213: [MATH-1651] fix flaky test in commons-math-neuralnet
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #213:
URL: https://github.com/apache/commons-math/pull/213#issuecomment-1283508981
# [Codecov](https://codecov.io/gh/apache/commons-math/pull/213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#213](https://codecov.io/gh/apache/commons-math/pull/213?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30463af) into [master](https://codecov.io/gh/apache/commons-math/commit/ec7eb8b32d9dff80f98c506a88c521a0ca3ea6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec7eb8b) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #213 +/- ##
============================================
- Coverage 86.55% 86.53% -0.03%
+ Complexity 9810 9807 -3
============================================
Files 533 533
Lines 35579 35580 +1
Branches 6212 6212
============================================
- Hits 30796 30789 -7
- Misses 3524 3528 +4
- Partials 1259 1263 +4
```
| [Impacted Files](https://codecov.io/gh/apache/commons-math/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/commons/math4/neuralnet/Network.java](https://codecov.io/gh/apache/commons-math/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1tYXRoLW5ldXJhbG5ldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9tYXRoNC9uZXVyYWxuZXQvTmV0d29yay5qYXZh) | `61.29% <100.00%> (+0.42%)` | :arrow_up: |
| [...th4/legacy/ml/clustering/FuzzyKMeansClusterer.java](https://codecov.io/gh/apache/commons-math/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1tYXRoLWxlZ2FjeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9tYXRoNC9sZWdhY3kvbWwvY2x1c3RlcmluZy9GdXp6eUtNZWFuc0NsdXN0ZXJlci5qYXZh) | `76.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...criptive/AbstractStorelessUnivariateStatistic.java](https://codecov.io/gh/apache/commons-math/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1tYXRoLWxlZ2FjeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9tYXRoNC9sZWdhY3kvc3RhdC9kZXNjcmlwdGl2ZS9BYnN0cmFjdFN0b3JlbGVzc1VuaXZhcmlhdGVTdGF0aXN0aWMuamF2YQ==) | `85.18% <0.00%> (-3.71%)` | :arrow_down: |
| [...optim/nonlinear/scalar/noderiv/CMAESOptimizer.java](https://codecov.io/gh/apache/commons-math/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9ucy1tYXRoLWxlZ2FjeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY29tbW9ucy9tYXRoNC9sZWdhY3kvb3B0aW0vbm9ubGluZWFyL3NjYWxhci9ub2Rlcml2L0NNQUVTT3B0aW1pemVyLmphdmE=) | `83.65% <0.00%> (-0.44%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] asfgit closed pull request #213: [MATH-1651] fix flaky test in commons-math-neuralnet
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #213: [MATH-1651] fix flaky test in commons-math-neuralnet
URL: https://github.com/apache/commons-math/pull/213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org