[GitHub] [lucene-solr] jimczi commented on a change in pull request #923: LUCENE-8988: Introduce Global Feature Based Early Termination For Sorted Fields

[GitBox <gi...@apache.org>]

jimczi commented on a change in pull request #923: LUCENE-8988: Introduce Global Feature Based Early Termination For Sorted Fields
URL: https://github.com/apache/lucene-solr/pull/923#discussion_r334351463
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/LeafFieldComparator.java
 ##########
 @@ -116,4 +116,12 @@
    * obtain the current hit's score, if necessary. */
   void setScorer(Scorable scorer) throws IOException;
 
+  /** Publishes feature values for the given docID
+   *  The passed in docID values should only move ahead --
+   *  DocValues do not support reverse iterations.
+   *  WARNING: Can be a costly API, especially for sorted fields
+   *
+   *  @param doc docID relative to current reader
+   */
+  T getDocValue(int doc) throws IOException;
 
 Review comment:
   I don't understand why this is needed, if you know the bottom slot you can simply call `FieldComparator::value(int)` ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org