[jira] [Commented] (OOZIE-1890) Make oozie-site empty and reconcile defaults between oozie-default and the code

["Azrael (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049596#comment-14049596 ] 

Azrael commented on OOZIE-1890:
-------------------------------

I added {{ConfigurationService.OozieConfigs}} to contains all the configuration from oozie-default and oozie-site.
{{OozieConfigs.OozieConfig}} consist of name and value, So no need code default.

{code:java}
long warnThresholdMs = ConfigurationService.OozieConfigs.getLong(WARN_THRESHOLD_KEY);
{code}



> Make oozie-site empty and reconcile defaults between oozie-default and the code
> -------------------------------------------------------------------------------
>
>                 Key: OOZIE-1890
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1890
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Robert Kanter
>
> As shwetha and puru suggested in OOZIE-1888, oozie-site vs oozie-default is a point of confusion for users.  We've also had issues in the past where they've had different values from each other and/or from the code's default (i.e. {{conf.get(PROP_NAME, DEFAULT_VALUE)}}).
> We should make oozie-default the only source of truth by:
> # Putting all configuration properties in oozie-default.
> # Making oozie-site empty; if the user wants to change a property, they can copy it out of the for-reference oozie-default.
> # Getting rid of the code defaults.  It's easy for these to be out of sync with oozie-default, leading to confusion.  They aren't used anyway because oozie-default should always be there (and will now have every property)
> This will require looking through all classes to make sure we're not missing anything from oozie-default and also checking that we put the proper default value (from all 3 sources) into oozie-default.  It may be nice to also reorder the properties in oozie-default alphabetically (and also do this going forward with new properties).
> Also, {{oozie.service.WorkflowAppService.system.libpath}} should be set to "/user/$\{user.name\}/share/lib" (which is what OOZIE-1888 wanted to do).



--
This message was sent by Atlassian JIRA
(v6.2#6252)