You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:44:22 UTC
[GitHub] [arrow-datafusion] carols10cents opened a new issue #1852: ballista-core allows unused imports
carols10cents opened a new issue #1852:
URL: https://github.com/apache/arrow-datafusion/issues/1852
**Describe the bug**
The `ballista-core` crate [is allowing unused imports in the whole crate](https://github.com/apache/arrow-datafusion/blob/67fe623bd5882d0ce567e3aa3145a96fdf563443/ballista/rust/core/src/lib.rs#L19), so there are many `use` statements throughout that aren't actually needed and are showing dependencies where none exist.
I think people working on the crate since that annotation was added have been under the impression that they'd get warnings if there were unused imports, so there's a bunch of cleanup that hasn't happened.
**To Reproduce**
Steps to reproduce the behavior:
- Remove the use of an import from some code in the `ballista-core` crate, but not the `use` statement itself
- Run `cargo check`
- Observe no warnings about unused imports
**Expected behavior**
- I expected to get a warning when removing all uses of an imported item so that I know it can be cleaned up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist closed issue #1852: ballista-core allows unused imports
Posted by GitBox <gi...@apache.org>.
Jimexist closed issue #1852:
URL: https://github.com/apache/arrow-datafusion/issues/1852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org