[GitHub] [skywalking] wu-sheng commented on a change in pull request #7177: fix avg response time of gRPC is not right.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7177:
URL: https://github.com/apache/skywalking/pull/7177#discussion_r658863803



##########
File path: apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/server/TracingServerCallListener.java
##########
@@ -82,6 +82,12 @@ public void onCancel() {
             throw t;
         } finally {
             ContextManager.stopSpan();
+            try {
+                AbstractSpan abstractSpan = ContextManager.activeSpan();
+                ContextManager.stopSpan(abstractSpan);

Review comment:
       This seems duplicated logic. What do you mean about this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org