[GitHub] [cassandra] blerer commented on a change in pull request #1061: CASSANDRA-16733(3.0): Add flag to disable ALTER...DROP COMPACT STORAGE statements

[GitBox <gi...@apache.org>]

blerer commented on a change in pull request #1061:
URL: https://github.com/apache/cassandra/pull/1061#discussion_r650754292



##########
File path: src/java/org/apache/cassandra/cql3/statements/AlterTableStatement.java
##########
@@ -290,6 +290,10 @@ public void validate(ClientState state)
                                                                     columnFamily()));
                 break;
             case DROP_COMPACT_STORAGE:
+
+                if (!DatabaseDescriptor.enableDropCompactStorage())
+                    throw new InvalidRequestException("DROP COMPACT STORAGE is disabled. Enable in cassandra.yaml to use.");

Review comment:
       That was my reasoning once you have run the command and saw the warning it is effectively too late :-(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org