You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/07 21:23:32 UTC

[GitHub] [arrow] MingyuZhong opened a new pull request #7915: Fix a bug BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

MingyuZhong opened a new pull request #7915:
URL: https://github.com/apache/arrow/pull/7915


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670799483


   good catch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670721481


   https://issues.apache.org/jira/browse/ARROW-9671


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670721077


   Looks like formatting needs to be run:
   
   ```
      template <typename T,
   -            typename = typename std::enable_if<std::is_integral<T>::value &&
   -                                               (sizeof(T) <= sizeof(uint64_t)), T>::type>
   +            typename = typename std::enable_if<
   +                std::is_integral<T>::value && (sizeof(T) <= sizeof(uint64_t)), T>::type>
      constexpr BasicDecimal128(T value) noexcept
   -      : BasicDecimal128(value >= T{0} ? 0 : -1,
   -                        static_cast<uint64_t>(value)) {}
   +      : BasicDecimal128(value >= T{0} ? 0 : -1, static_cast<uint64_t>(value)) {}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield closed pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

Posted by GitBox <gi...@apache.org>.
emkornfield closed pull request #7915:
URL: https://github.com/apache/arrow/pull/7915


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7915:
URL: https://github.com/apache/arrow/pull/7915#issuecomment-670813455


   It seems travis is having issues today.  I'm going to go ahead and merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org