You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "momo-jun (via GitHub)" <gi...@apache.org> on 2023/03/02 08:14:31 UTC
[GitHub] [pulsar-site] momo-jun opened a new pull request, #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
momo-jun opened a new pull request, #448:
URL: https://github.com/apache/pulsar-site/pull/448
Fixes https://github.com/apache/pulsar/issues/19684
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#issuecomment-1452909742
Thanks @jak78 for pointing out that the `docker-compose` command (with a dash) is being deprecated in favor of `docker compose` (without a dash), and the `docker-compose.yml` will be named `compose.yml`.
@liangyepianzhou It seems the original ones will not be supported by the end of June 2023. Shall we apply the change right now or document anything to help users to switch to [Compose V2](https://docs.docker.com/compose/reference/)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] asafm commented on a diff in pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on code in PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#discussion_r1123184850
##########
docs/getting-started-home.md:
##########
@@ -8,5 +8,5 @@ Getting up and running with Pulsar is simple. Download it, install it, and try i
You have three options. Click any of these links to begin your Pulsar journey!
* [Run a standalone Pulsar cluster locally](getting-started-standalone.md) - Run a single instance of Pulsar in standalone mode on a single machine.
-* [Run a standalone Pulsar cluster in Docker](getting-started-docker.md) - Run one or more instances of Pulsar in a Docker container.
+* [Run a standalone Pulsar cluster in Docker](getting-started-docker.md) - Run one or more instances of Pulsar in a Docker container. If you want to quickly set up a small Pulsar cluster on your local laptop, go to [Run a Pulsar cluster with `docker-compose`](getting-started-docker-compose.md).
Review Comment:
"with `docker-compose`" --> "with Docker Compose"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#issuecomment-1451811593
@asafm Can you pls review this PR?
I noticed that it may have a conflict with your PR https://github.com/apache/pulsar-site/pull/441. If yours is merged first, I can resolve the conflict to ensure both updates are in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#discussion_r1122790333
##########
docs/getting-started-docker-compose.md:
##########
@@ -0,0 +1,119 @@
+---
+id: getting-started-docker-compose
+title: Run a Pulsar cluster locally with `docker-compose`
+sidebar_label: "Run Pulsar locally with `docker-compose`"
Review Comment:
Thanks for pointing it out. Resolved in [b52acfa](https://github.com/apache/pulsar-site/pull/448/commits/b52acfaad99aefe158556af2bb4c442fa4ca5809).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#issuecomment-1453295579
> IMO, we should apply the change right now and there is no need to keep the deprecated version.
Thank you. As discussed, @liangyepianzhou will help verify the cmd change and I will update the doc accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#discussion_r1122746102
##########
docs/develop-schema.md:
##########
@@ -1,62 +0,0 @@
----
Review Comment:
Is removing this page related to the PR topic? And why we remove this page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#discussion_r1122777417
##########
docs/getting-started-docker-compose.md:
##########
@@ -0,0 +1,119 @@
+---
+id: getting-started-docker-compose
+title: Run a Pulsar cluster locally with `docker-compose`
+sidebar_label: "Run Pulsar locally with `docker-compose`"
Review Comment:
```suggestion
title: Run a Pulsar cluster locally with Docker Compose
sidebar_label: "Run Pulsar locally with Docker Compose"
```
Use the formal text name. See https://docs.docker.com/compose/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] liangyepianzhou commented on pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#issuecomment-1453308568
I have tested this `docker-compose.yml` file with the new `docker compose`.
After applying the changes, the cluster can be properly deployed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] asafm commented on pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#issuecomment-1451957245
The image has a title of "`docker compose`". Should be Docker Compose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#discussion_r1123965650
##########
docs/getting-started-home.md:
##########
@@ -8,5 +8,5 @@ Getting up and running with Pulsar is simple. Download it, install it, and try i
You have three options. Click any of these links to begin your Pulsar journey!
* [Run a standalone Pulsar cluster locally](getting-started-standalone.md) - Run a single instance of Pulsar in standalone mode on a single machine.
-* [Run a standalone Pulsar cluster in Docker](getting-started-docker.md) - Run one or more instances of Pulsar in a Docker container.
+* [Run a standalone Pulsar cluster in Docker](getting-started-docker.md) - Run one or more instances of Pulsar in a Docker container. If you want to quickly set up a small Pulsar cluster on your local laptop, go to [Run a Pulsar cluster with `docker-compose`](getting-started-docker-compose.md).
Review Comment:
Right! I missed this one. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] liangyepianzhou commented on pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou commented on PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#issuecomment-1453282045
IMO, we should apply the change right now and there is no need to keep the deprecated version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #448:
URL: https://github.com/apache/pulsar-site/pull/448#discussion_r1122773688
##########
docs/develop-schema.md:
##########
@@ -1,62 +0,0 @@
----
Review Comment:
Not really, but it's a duplicate page and might be added unexpectedly. The content is presented in [here](https://pulsar.apache.org/docs/next/schema-get-started/#customize-schema-storage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] liangyepianzhou merged pull request #448: [improve][doc] Relocate `docker-compose` content to `Get Started` category
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou merged PR #448:
URL: https://github.com/apache/pulsar-site/pull/448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org