[GitHub] [superset] villebro commented on a change in pull request #16957: fix(filterset): failed to parse json_metadata json on creating new filterset

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16957:
URL: https://github.com/apache/superset/pull/16957#discussion_r721516528



##########
File path: superset/dashboards/filter_sets/schemas.py
##########
@@ -34,7 +34,7 @@ class JsonMetadataSchema(Schema):
 
 
 class FilterSetSchema(Schema):
-    json_metadata_schema: JsonMetadataSchema = JsonMetadataSchema()
+    json_metadata_schema: JsonMetadataSchema = JsonMetadataSchema(unknown=INCLUDE)

Review comment:
       We've hit these kinds of problems on the previous schema definitions before, and I wonder if we should just go with a raw schema for these JSON blobs for now? Having a defined schema but allowing for `unknown=INCLUDE` doesn't feel totally right - on one hand we're enforcing schema, but in practice not really. Thoughts?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org