You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Raviston6296 (via GitHub)" <gi...@apache.org> on 2025/12/25 14:35:47 UTC
[PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Raviston6296 opened a new pull request, #53613:
URL: https://github.com/apache/spark/pull/53613
### What changes were proposed in this pull request?
This PR updates documentation/comments related to executor
OutOfMemoryError handling to clarify that JVM termination on OOM
is optional and should be explicitly configured by users.
### Why are the changes needed?
The existing comments assume executors must be killed on OOM,
which can obscure failure reasons. This update aligns the
documentation with the intent discussed in SPARK-50186.
### Does this PR introduce any user-facing change?
No. This is a documentation-only change.
### How was this patch tested?
N/A (comment-only change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-4218950743
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #53613: [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs
URL: https://github.com/apache/spark/pull/53613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "Raviston6296 (via GitHub)" <gi...@apache.org>.
Raviston6296 commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3698886282
Then i close this PR or need to document this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3698397879
There is no `spark.executor.killOnOutOfMemoryError` flag in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "Raviston6296 (via GitHub)" <gi...@apache.org>.
Raviston6296 commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3698588771
> There is no `spark.executor.killOnOutOfMemoryError` flag in Spark.
Can we include this flag in spark ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "Raviston6296 (via GitHub)" <gi...@apache.org>.
Raviston6296 commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3694771406
hi team kindly check this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "Raviston6296 (via GitHub)" <gi...@apache.org>.
Raviston6296 commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3693097682
Someone kindly review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "Raviston6296 (via GitHub)" <gi...@apache.org>.
Raviston6296 commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3692008352
@HyukjinKwon kindly review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50186][CORE] Clarify executor OutOfMemoryError handling docs [spark]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #53613:
URL: https://github.com/apache/spark/pull/53613#issuecomment-3698605500
You dont need to introduce it - simply override `OnOutOfMemoryError` with something benign to prevent kill : when specified, the existing code already skips addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org