Re: [PR] [GLUTEN-9949][VL] Enable enhanced features compile [incubator-gluten]

["zhztheplayer (via GitHub)" <gi...@apache.org>]

zhztheplayer commented on code in PR #9957:
URL: https://github.com/apache/incubator-gluten/pull/9957#discussion_r2142305637


##########
gluten-core/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -117,6 +117,9 @@ class GlutenConfig(conf: SQLConf) extends Logging {
   def enableExtendedColumnPruning: Boolean =
     getConf(ENABLE_EXTENDED_COLUMN_PRUNING)
 
+  def enableEnhancedFeature(): Boolean =
+    System.getenv().getOrDefault("GLUTEN_ENABLE_ENHANCED_FEATURE", "false").toBoolean
+

Review Comment:
   @jinchengchenghh Got it. I think we need a backend API for the feature then. E.g., `BackendSettingsApi#isEnhancedFeatureEnabled()`
   
   For CH backend, we can make it false by default.
   
   Then we can move `ConfigJniWrapper.java` which I see is newly added to `gluten-core` to `backends-velox`. This is to follow the rule that we don't put any JNI code to `gluten-core` so it's more flexible for backends.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org