[GitHub] [superset] jinghua-qa commented on pull request #18793: feat: Adds support to multiple dependencies to the native filters

[GitBox <gi...@apache.org>]

jinghua-qa commented on pull request #18793:
URL: https://github.com/apache/superset/pull/18793#issuecomment-1054831313


   > > > When user select a scope for the filter, the scope of the chart information will not show in the tooltip? When the filter apply to all it will show " apply to all charts", but if it is only applied to selected chart or tab it did not show which scope it is in the tooltip, is this expected?
   > > > Screen.Recording.2022-02-25.at.3.33.54.PM.mov
   > > 
   > > 
   > > Yes - tooltip shows only when text is truncated. I think there's no point in listing every chart in the dashboard when scope is "All charts". As for the second case - yes, not showing "Scope" row when nothing is in scope was intentional. I can add a row "Scope: None", but I don't think there's a point in creating a filter with nothing in scope and then opening "Out of scope panel" to see that filter. @kasiazjc wdyt?
   > 
   > For "All charts" we won't be showing a tooltip, because as Kamil said it does not make sense to list all of the charts/tabs. If there is no scope added though we should still keep the "scope" row with value "none" as it is a valuable information for the user who is looking for information about the filter.
   
   Thank you for your explanation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org