You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/03/01 06:06:47 UTC

[GitHub] [incubator-dolphinscheduler] lijufeng2016 commented on a change in pull request #4877: [FIX-4876]Http alert plugin fix

lijufeng2016 commented on a change in pull request #4877:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4877#discussion_r584465072



##########
File path: dolphinscheduler-alert-plugin/dolphinscheduler-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java
##########
@@ -110,17 +114,17 @@ public AlertResult send(String msg) {
     }
 
     private void createHttpRequest(String msg) {
-
         if (REQUEST_TYPE_POST.equals(requestType)) {
             httpRequest = new HttpPost(url);
+            setHeader();
             //POST request add param in request body
             setMsgInRequestBody(msg);

Review comment:
       Header is required set by user on ui page,I just get header by user set.
   header是用户在界面上必须要配置的，我只是从用户配置的header取的值
   ![微信图片_20210301140515.png](http://ww1.sinaimg.cn/large/005Cc2n2ly1go4de8hh1wj30f50gfgm5.jpg)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org