You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Kenji Nagahashi (JIRA)" <de...@myfaces.apache.org> on 2006/04/03 10:11:43 UTC

[jira] Created: (MYFACES-1196) h:panelGrid columnClasses: classes are not used repetitively

h:panelGrid columnClasses: classes are not used repetitively
------------------------------------------------------------

         Key: MYFACES-1196
         URL: http://issues.apache.org/jira/browse/MYFACES-1196
     Project: MyFaces Core
        Type: Bug

  Components: General  
    Versions: 1.1.1    
    Reporter: Kenji Nagahashi


Classes specified in columnClasses attribute of h:panelGrid should be reused when number of classes are less than the number of columns. This behavior is not implemented.
In org.apache.myfaces.renderkit.html.HtmlGridRendererBase.java, renderChildren method, columnClassesArray needs to be indexed by another index variable, say, columnClassIndex, not by columnIndex.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MYFACES-1196) h:panelGrid columnClasses: classes are not used repetitively

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-1196?page=all ]

Bruno Aranda updated MYFACES-1196:
----------------------------------

         Status: Resolved  (was: Patch Available)
    Fix Version: 1.1.4-SNAPSHOT
     Resolution: Invalid

I am afraid we cannot accept this patch as the behaviour would violate the JSF specification. Look at the render-kit JavaDocs [1] for more info. It states than if the number of classes is less than the number of columns, no class attribute should be rendered for those columns.
Sorry for making you create a patch!

[1] http://java.sun.com/javaee/javaserverfaces/1.1/docs/renderkitdocs/

> h:panelGrid columnClasses: classes are not used repetitively
> ------------------------------------------------------------
>
>          Key: MYFACES-1196
>          URL: http://issues.apache.org/jira/browse/MYFACES-1196
>      Project: MyFaces Core
>         Type: Bug

>   Components: General
>     Versions: 1.1.1
>     Reporter: Kenji Nagahashi
>      Fix For: 1.1.4-SNAPSHOT
>  Attachments: myfaces-1196.patch.txt
>
> Classes specified in columnClasses attribute of h:panelGrid should be reused when number of classes are less than the number of columns. This behavior is not implemented.
> In org.apache.myfaces.renderkit.html.HtmlGridRendererBase.java, renderChildren method, columnClassesArray needs to be indexed by another index variable, say, columnClassIndex, not by columnIndex.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1196) h:panelGrid columnClasses: classes are not used repetitively

Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1196?page=comments#action_12414496 ] 

Grant Smith commented on MYFACES-1196:
--------------------------------------

Kenji,

If possible, please provide a patch to save us time :)

Thanks

> h:panelGrid columnClasses: classes are not used repetitively
> ------------------------------------------------------------
>
>          Key: MYFACES-1196
>          URL: http://issues.apache.org/jira/browse/MYFACES-1196
>      Project: MyFaces Core
>         Type: Bug

>   Components: General
>     Versions: 1.1.1
>     Reporter: Kenji Nagahashi

>
> Classes specified in columnClasses attribute of h:panelGrid should be reused when number of classes are less than the number of columns. This behavior is not implemented.
> In org.apache.myfaces.renderkit.html.HtmlGridRendererBase.java, renderChildren method, columnClassesArray needs to be indexed by another index variable, say, columnClassIndex, not by columnIndex.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MYFACES-1196) h:panelGrid columnClasses: classes are not used repetitively

Posted by "Kenji Nagahashi (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-1196?page=all ]

Kenji Nagahashi updated MYFACES-1196:
-------------------------------------

    Status: Patch Available  (was: Open)

> h:panelGrid columnClasses: classes are not used repetitively
> ------------------------------------------------------------
>
>          Key: MYFACES-1196
>          URL: http://issues.apache.org/jira/browse/MYFACES-1196
>      Project: MyFaces Core
>         Type: Bug

>   Components: General
>     Versions: 1.1.1
>     Reporter: Kenji Nagahashi

>
> Classes specified in columnClasses attribute of h:panelGrid should be reused when number of classes are less than the number of columns. This behavior is not implemented.
> In org.apache.myfaces.renderkit.html.HtmlGridRendererBase.java, renderChildren method, columnClassesArray needs to be indexed by another index variable, say, columnClassIndex, not by columnIndex.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira