You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2024/02/29 09:28:30 UTC
[PR] [CELEBORN-1298] Support Spark2.4 with Scala2.12 [incubator-celeborn]
waitinfuture opened a new pull request, #2344:
URL: https://github.com/apache/incubator-celeborn/pull/2344
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
As title
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1298] Support Spark2.4 with Scala2.12 [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2344:
URL: https://github.com/apache/incubator-celeborn/pull/2344#discussion_r1507287886
##########
README.md:
##########
@@ -67,6 +67,17 @@ package apache-celeborn-${project.version}-bin.tgz will be generated.
| Flink 1.17 | ❌ | ✔ | ✔ | ❌ | ❌ | ❌ | ❌ |
| Flink 1.18 | ❌ | ✔ | ✔ | ❌ | ❌ | ❌ | ❌ |
+To compile Spark 2.4 with Scala 2.12, please use the following command
+
+#### Scala 2.12.8/2.12.9/2.12.10
+```shell
+./build/make-distribution.sh -DskipTests -Pspark-2.4 -Dscala.version=${scala.version} -Dscala.binary.version=2.12 -Dmaven.plugin.scala.version=3.2.2 -Dmaven.plugin.silencer.version=1.6.0
+```
+#### Scala 2.12.13-2.12.18
Review Comment:
```suggestion
- Scala 2.12.13-2.12.18
```
##########
README.md:
##########
@@ -67,6 +67,17 @@ package apache-celeborn-${project.version}-bin.tgz will be generated.
| Flink 1.17 | ❌ | ✔ | ✔ | ❌ | ❌ | ❌ | ❌ |
| Flink 1.18 | ❌ | ✔ | ✔ | ❌ | ❌ | ❌ | ❌ |
+To compile Spark 2.4 with Scala 2.12, please use the following command
+
+#### Scala 2.12.8/2.12.9/2.12.10
Review Comment:
```suggestion
- Scala 2.12.8/2.12.9/2.12.10
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1298] Support Spark2.4 with Scala2.12 [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2344:
URL: https://github.com/apache/incubator-celeborn/pull/2344#issuecomment-1970767216
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 48.87%. Comparing base [(`6d9fbf5`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/6d9fbf5e490b161db90f6a9ed719260130136410?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a59480b`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
- Coverage 48.97% 48.87% -0.10%
==========================================
Files 207 207
Lines 12965 12965
Branches 1113 1113
==========================================
- Hits 6348 6335 -13
- Misses 6211 6223 +12
- Partials 406 407 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2344?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1298] Support Spark2.4 with Scala2.12 [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2344: [CELEBORN-1298] Support Spark2.4 with Scala2.12
URL: https://github.com/apache/incubator-celeborn/pull/2344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1298] Support Spark2.4 with Scala2.12 [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2344:
URL: https://github.com/apache/incubator-celeborn/pull/2344#issuecomment-1970780025
Thanks, merging to main(v0.5.0)/branch-0.4(v0.4.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1298] Support Spark2.4 with Scala2.12 [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #2344:
URL: https://github.com/apache/incubator-celeborn/pull/2344#discussion_r1507276630
##########
README.md:
##########
@@ -67,6 +67,17 @@ package apache-celeborn-${project.version}-bin.tgz will be generated.
| Flink 1.17 | ❌ | ✔ | ✔ | ❌ | ❌ | ❌ | ❌ |
| Flink 1.18 | ❌ | ✔ | ✔ | ❌ | ❌ | ❌ | ❌ |
+To compile Spark 2.4 with Scala 2.12, please use the following command
Review Comment:
```suggestion
To compile the client for Spark 2.4 with Scala 2.12, please use the following command
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org