You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/07 03:36:17 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #16626: Recover ShardingSphereServiceLoader.register in classes which is removed before

sandynz opened a new pull request, #16626:
URL: https://github.com/apache/shardingsphere/pull/16626

   Purpose:
   - Recover `ShardingSphereServiceLoader.register` for later refactoring. Based on discussion with @terrymanu , 1) if users use SingletonSPIRegistry by mistake, `ShardingSphereServiceLoader.register` might be invoked repeatedly, it might hurt performance, 2) singleton should not be SPI interface level, it could be annotation, 3) most SPI should be singleton, auto register might be the default behavior later.
   
   Changes proposed in this pull request:
   - Remove `ShardingSphereServiceLoader.register` in `RequiredSPIRegistry` and `SingletonSPIRegistry`
   - Recover `ShardingSphereServiceLoader.register` in referenced classes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu merged pull request #16626: Recover ShardingSphereServiceLoader.register in classes which is removed before

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #16626:
URL: https://github.com/apache/shardingsphere/pull/16626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #16626: Recover ShardingSphereServiceLoader.register in classes which is removed before

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16626:
URL: https://github.com/apache/shardingsphere/pull/16626#issuecomment-1091094114

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16626](https://codecov.io/gh/apache/shardingsphere/pull/16626?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (14982f6) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f5d3a742090d6490da789980f53b7db1275b1844?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f5d3a74) will **decrease** coverage by `0.07%`.
   > The diff coverage is `52.38%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #16626      +/-   ##
   ============================================
   - Coverage     60.74%   60.66%   -0.08%     
   - Complexity     2094     2095       +1     
   ============================================
     Files          3349     3368      +19     
     Lines         50690    50757      +67     
     Branches       8713     8716       +3     
   ============================================
   + Hits          30793    30794       +1     
   - Misses        17307    17373      +66     
     Partials       2590     2590              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...urce/creator/PipelineDataSourceCreatorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvZGF0YXNvdXJjZS9jcmVhdG9yL1BpcGVsaW5lRGF0YVNvdXJjZUNyZWF0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...re/ingest/position/PositionInitializerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW5nZXN0L3Bvc2l0aW9uL1Bvc2l0aW9uSW5pdGlhbGl6ZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ine/core/sqlbuilder/PipelineSQLBuilderFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvc3FsYnVpbGRlci9QaXBlbGluZVNRTEJ1aWxkZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...e/scenario/rulealtered/RuleAlteredJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...phere/data/pipeline/api/PipelineJobAPIFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL1BpcGVsaW5lSm9iQVBJRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...eline/api/config/rulealtered/JobConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL2NvbmZpZy9ydWxlYWx0ZXJlZC9Kb2JDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...sphere/proxy/initializer/BootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9Cb290c3RyYXBJbml0aWFsaXplci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gsphere/spi/type/required/RequiredSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcGkvdHlwZS9yZXF1aXJlZC9SZXF1aXJlZFNQSVJlZ2lzdHJ5LmphdmE=) | `100.00% <ø> (ø)` | |
   | [...phere/spi/type/singleton/SingletonSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcGkvdHlwZS9zaW5nbGV0b24vU2luZ2xldG9uU1BJUmVnaXN0cnkuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...unication/jdbc/statement/JDBCBackendStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L0pEQkNCYWNrZW5kU3RhdGVtZW50LmphdmE=) | `36.00% <75.00%> (ø)` | |
   | ... and [47 more](https://codecov.io/gh/apache/shardingsphere/pull/16626/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16626?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16626?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f5d3a74...14982f6](https://codecov.io/gh/apache/shardingsphere/pull/16626?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org