You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/06/19 19:10:20 UTC
Review Request 70904: Added tests for task killing when draining the
agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
Added tests for task killing when draining the agent.
Diffs
-----
src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271
Diff: https://reviews.apache.org/r/70904/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 70904: Added tests for task killing when draining
the agent.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/#review216194
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/slave_tests.cpp
Lines 11916-11917 (patched)
<https://reviews.apache.org/r/70904/#comment303276>
nit:Let's move this right after `subscribed` handling above.
src/tests/slave_tests.cpp
Lines 12034-12035 (patched)
<https://reviews.apache.org/r/70904/#comment303277>
See above.
src/tests/slave_tests.cpp
Lines 12147 (patched)
<https://reviews.apache.org/r/70904/#comment303278>
See above.
src/tests/slave_tests.cpp
Lines 12173 (patched)
<https://reviews.apache.org/r/70904/#comment303279>
Nice.
- Benjamin Bannier
On June 25, 2019, 10:23 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70904/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 10:23 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for task killing when draining the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271
>
>
> Diff: https://reviews.apache.org/r/70904/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70904: Added tests for task killing when draining
the agent.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/#review216568
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 1, 2019, 12:58 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70904/
> -----------------------------------------------------------
>
> (Updated July 1, 2019, 12:58 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for task killing when draining the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 5d930bd81c349d11fa980433f2541a2f968ddeb0
>
>
> Diff: https://reviews.apache.org/r/70904/diff/3/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70904: Added tests for task killing when draining
the agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/
-----------------------------------------------------------
(Updated July 1, 2019, 7:58 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
Added tests for task killing when draining the agent.
Diffs (updated)
-----
src/tests/slave_tests.cpp 5d930bd81c349d11fa980433f2541a2f968ddeb0
Diff: https://reviews.apache.org/r/70904/diff/3/
Changes: https://reviews.apache.org/r/70904/diff/2-3/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70904: Added tests for task killing when draining
the agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/
-----------------------------------------------------------
(Updated June 25, 2019, 8:23 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
Added tests for task killing when draining the agent.
Diffs (updated)
-----
src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271
Diff: https://reviews.apache.org/r/70904/diff/2/
Changes: https://reviews.apache.org/r/70904/diff/1-2/
Testing
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 70904: Added tests for task killing when draining
the agent.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/#review215985
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70822, 70839, 70834, 70835, 70836, 70899, 70900, 70901, 70903, 70904]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 19, 2019, 12:33 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70904/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 12:33 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
>
>
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for task killing when draining the agent.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271
>
>
> Diff: https://reviews.apache.org/r/70904/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 70904: Added tests for task killing when draining
the agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/
-----------------------------------------------------------
(Updated June 19, 2019, 7:33 p.m.)
Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821
Repository: mesos
Description
-------
Added tests for task killing when draining the agent.
Diffs
-----
src/tests/slave_tests.cpp c2035976713abb31b3646c0d23771fa40df93271
Diff: https://reviews.apache.org/r/70904/diff/1/
Testing (updated)
-------
`make check`
`bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann