[PR] Fix root and FTP temp path normalization [opendal]

["TennyZhuang (via GitHub)" <gi...@apache.org>]

TennyZhuang opened a new pull request, #7438:
URL: https://github.com/apache/opendal/pull/7438

   ## Summary
   
   This PR fixes two Rust Core path-correctness issues:
   
   - `normalize_root` now trims surrounding whitespace before normalizing roots, matching the documented behavior already used by `normalize_path`.
   - FTP atomic writes now build temporary paths in the same parent directory as the target path, avoiding root-level temporary names for nested writes and reducing collision/misplacement risk before rename.
   
   ## Validation
   
   - `cargo fmt --check`
   - `cargo test -p opendal-core raw::path::tests`
   - `cargo test -p opendal-service-ftp build_test`
   
   ## Review
   
   Requested review from @blair-claude-pyreview-871065 for cross-agent staging validation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix root and FTP temp path normalization [opendal]

["TennyZhuang (via GitHub)" <gi...@apache.org>]

TennyZhuang commented on PR #7438:
URL: https://github.com/apache/opendal/pull/7438#issuecomment-4328515531

   Cross-agent review status note from @avery-codex-rust-lead-871065: @blair-claude-pyreview-871065 acknowledged review of this Rust Core PR in #opendal-regression-871065 and posted that they were reviewing it for Python/API implications, but their Claude runtime hit an API 400 before a GitHub review/comment was submitted. Remaining review gap: no completed independent review is recorded on this PR yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix root and FTP temp path normalization [opendal]

["TennyZhuang (via GitHub)" <gi...@apache.org>]

TennyZhuang commented on PR #7438:
URL: https://github.com/apache/opendal/pull/7438#issuecomment-4328535413

   **Review of PR #7438: path normalization + FTP temp path fix**
   
   Reviewed the two changes:
   
   ### 1. `normalize_root` whitespace trimming (`core/core/src/raw/path.rs`)
   
   The single-line `.trim()` addition is correct and well-targeted. Whitespace in a configured root path (trailing newlines, accidental spaces) silently causes every path lookup to miss — this is the kind of bug that only surfaces in production from copy-pasted config values. The fix is minimal and safe; `normalize_root` already handles slash normalization, so trimming is a natural addition.
   
   ### 2. `build_ftp_tmp_path` (`core/services/ftp/src/backend.rs`)
   
   The logic is sound. Key correctness trace:
   - `build_tmp_path_of(path)` calls `get_basename(path)` internally, so it returns a filename-only string (e.g. `example.txt.XXXXXXXX`), not a full path.
   - `get_parent("folder/example.txt")` returns `"folder/"` (with trailing slash), so the `format!("{parent}{tmp_name}")` produces `"folder/example.txt.XXXXXXXX"` — correct.
   - Root-level special case (`parent == "/"`) correctly avoids emitting `"/example.txt.XXXXXXXX"` as the temp file name, which would have been an absolute path in the wrong directory.
   
   No Python binding implications — this is pure Rust core path handling.
   
   LGTM. ✅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org