[GitHub] [apisix-ingress-controller] lingsamuel commented on a diff in pull request #1079: feat: support GatewayClass, refactor gateway modules

[GitBox <gi...@apache.org>]

lingsamuel commented on code in PR #1079:
URL: https://github.com/apache/apisix-ingress-controller/pull/1079#discussion_r897688362


##########
pkg/ingress/namespace/namespace.go:
##########
@@ -22,21 +22,28 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/util/workqueue"
 
 	"github.com/apache/apisix-ingress-controller/pkg/log"
 	"github.com/apache/apisix-ingress-controller/pkg/types"
 )
 
+// FIXME: Controller should be the Core Part,
+// Provider should act as "EventHandler", register there functions to Controller

Review Comment:
   Yes. The core concept here is that the providers shouldn't interact directly with the controller's field, for example add event handlers directly to the informers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org