You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/02 00:14:07 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #9623: Move ElasticsearchTaskHandler to the provider package
ephraimbuddy opened a new pull request #9623:
URL: https://github.com/apache/airflow/pull/9623
---
This PR fixes one of the issues listed in #9386
The `ElasticsearchTaskHandler` class from `airflow.utils.log.es_task_handler` was moved to
`airflow.providers.elasticsearch.log.es_task_handler`.
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653056290
Look at the logs @ephraimbuddy -> the "ExternalLoggingMixin" is a bit strange as I cannot see it in the logging_mixin. Where is it from?
----------------------------------------
Traceback (most recent call last):
File "/import_all_provider_classes.py", line 61, in import_all_provider_classes
_module = importlib.import_module(module_name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/usr/local/lib/python3.6/site-packages/airflow/providers/elasticsearch/log/es_task_handler.py", line 34, in <module>
from airflow.utils.log.logging_mixin import ExternalLoggingMixin, LoggingMixin
ImportError: cannot import name 'ExternalLoggingMixin'
----------------------------------------
ERROR ENCOUNTERED!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653009423
@ephraimbuddy can you please take a look at the CI errors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653044347
Hi @turbaszek , what could be the cause of the backport packages CI build error? I can't seem to figure it out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653188369
@potiuk This will cherry-pick changes to the Javascript code. If you are willing, we can do it. For now, we should delete references to this class in backport packages. This will allow these classes to be used without this one new feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653059073
If we want to support ExternalLoggingMixin we should also bacport it to 1.10 but this might be a bit more complex - using Bowler refactoring (@turbaszek WDYT?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653948106
These changes have been move to #9604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653060319
@potiuk Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #9623:
URL: https://github.com/apache/airflow/pull/9623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9623: Move ElasticsearchTaskHandler to the provider package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653057551
We can't use ExtenralLoggingMixin in Airflow 1.10 providers because it only appeared .... TODAY in master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org