You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/01/26 02:45:01 UTC
[GitHub] [incubator-brpc] hcoona opened a new issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
hcoona opened a new issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684
https://github.com/apache/incubator-brpc/blob/2c98d0a49312c02b6208e842cf23a164a1bba5ce/src/brpc/details/load_balancer_with_naming.cpp#L37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin closed issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
TousakaRin closed issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684#issuecomment-1022816291
看了下百度内部版本这块已经改成ERROR级别了，而且是2017年8月改的，不知道为啥没有同步到社区
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684#issuecomment-1021887320
Do you mean that "LOG(FATAL)" causes abort so "return -1" will not be executed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] hcoona commented on issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
hcoona commented on issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684#issuecomment-1022090848
@cdjingit 我补充一下背景。这个问题是这样的，本地的 SD 配置有错误，或者别的什么原因，此时拿到的 server 列表是空的。我们希望能够感知到这一问题，做一些清理再退出。目前的实现有这样 2 种可能：
1. 直接 `LOG(FATAL)` core 掉，这个不太好，我们还想做点事情
2. 设置 `log_succeed_without_server` 忽略掉这个错误，这个也不好，我们的请求都会卡住，我们希望能够识别出这个问题并进行一些处理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] guodongxiaren commented on issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
guodongxiaren commented on issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684#issuecomment-1022809263
glog的fatal日志，就是会导致core的。这里可以改成error级别。我之前也提过类似的PR #1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] hcoona commented on issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
hcoona commented on issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684#issuecomment-1023843830
哈哈，这个说法要让社区伤心了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] cdjingit commented on issue #1684: LoadBalancerWithNaming::Init LOG(FATAL) prevent return -1
Posted by GitBox <gi...@apache.org>.
cdjingit commented on issue #1684:
URL: https://github.com/apache/incubator-brpc/issues/1684#issuecomment-1021814101
naming service配置的不对，贴下channel.Init()的代码呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org