You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/06 07:10:06 UTC
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15657
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
[master] KUDU-2798 fix logging on deleted TSK entries
Decode the identifiers of the deleted TSK entries while logging. Prior
to this patch, the raw value of the system catalog's 'entry_id' column
was written into the log.
Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
3 files changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15657/1
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15657 )
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/catalog_manager.cc@4592
PS2, Line 4592: for (const auto& entry_id : entry_ids) {
: msg += Substitute(" $0", SysCatalogTable::TskEntryIdToSeqNumber(entry_id));
: }
> JoinMapped() is a pretty handy way to do loop transformations like these.
Done
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/sys_catalog.cc@636
PS2, Line 636: false, nullptr,
> Nit: annotate with comments what these mean?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 00:45:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15657 )
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
[master] KUDU-2798 fix logging on deleted TSK entries
Decode the identifiers of the deleted TSK entries while logging. Prior
to this patch, the raw value of the system catalog's 'entry_id' column
was written into the log.
Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Reviewed-on: http://gerrit.cloudera.org:8080/15657
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
3 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15657
to look at the new patch set (#2).
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
[master] KUDU-2798 fix logging on deleted TSK entries
Decode the identifiers of the deleted TSK entries while logging. Prior
to this patch, the raw value of the system catalog's 'entry_id' column
was written into the log.
Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
3 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15657/2
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15657 )
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/catalog_manager.cc@4592
PS2, Line 4592: for (const auto& entry_id : entry_ids) {
: msg += Substitute(" $0", SysCatalogTable::TskEntryIdToSeqNumber(entry_id));
: }
JoinMapped() is a pretty handy way to do loop transformations like these.
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:
http://gerrit.cloudera.org:8080/#/c/15657/2/src/kudu/master/sys_catalog.cc@636
PS2, Line 636: false, nullptr,
Nit: annotate with comments what these mean?
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Apr 2020 22:37:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15657
to look at the new patch set (#3).
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
[master] KUDU-2798 fix logging on deleted TSK entries
Decode the identifiers of the deleted TSK entries while logging. Prior
to this patch, the raw value of the system catalog's 'entry_id' column
was written into the log.
Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
3 files changed, 23 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15657/3
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [master] KUDU-2798 fix logging on deleted TSK entries
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15657 )
Change subject: [master] KUDU-2798 fix logging on deleted TSK entries
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c7ba7fd2277fff1176eca51d59404deebe38c4
Gerrit-Change-Number: 15657
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 01:04:02 +0000
Gerrit-HasComments: No