[GitHub] [hadoop] ayushtkn commented on pull request #4488: HDFS-16640. RBF: Show datanode IP list when click DN histogram in Router

[GitBox <gi...@apache.org>]

ayushtkn commented on PR #4488:
URL: https://github.com/apache/hadoop/pull/4488#issuecomment-1164231208

   >it would be good to extract some if this common code.
   
   Not an expert with Javascript either, but I feel this should be possible. If we extract all these common methods into some other Javascript file say Utils.js and then add that in both dfsHealth.html and FederationHealth.html before these .js files like:
   
   ```
   </script><script type="text/javascript" src="/static/util.js">
   ```
   
   then may be we can get away from this copy-paste stuff
   
   @wzhallright can you give it a try for the methods that you copied or if you know a better way to avoid this duplication....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org