[GitHub] [drill] KazydubB commented on a change in pull request #1861: DRILL-7380: Query of a field inside of an array of structs returns null

[GitBox <gi...@apache.org>]

KazydubB commented on a change in pull request #1861: DRILL-7380: Query of a field inside of an array of structs returns null
URL: https://github.com/apache/drill/pull/1861#discussion_r328612943
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java
 ##########
 @@ -233,28 +288,26 @@ public void setup(OperatorContext context, OutputMutator output) throws Executio
       this.operatorContext = context;
       schema = footer.getFileMetaData().getSchema();
       MessageType projection;
+      final List<SchemaPath> columnsNotFound = new ArrayList<>(getColumns().size());
 
       if (isStarQuery()) {
         projection = schema;
       } else {
-        columnsNotFound = new ArrayList<>();
         projection = getProjection(schema, getColumns(), columnsNotFound);
         if (projection == null) {
           projection = schema;
         }
-        if (columnsNotFound != null && columnsNotFound.size() > 0) {
-          nullFilledVectors = new ArrayList<>();
-          for (SchemaPath col: columnsNotFound) {
+        if (columnsNotFound.size() > 0) {
 
 Review comment:
   Change to `!columnsNotFound.isEmpty()` :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services