You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Seth Voltz <se...@designgods.net> on 2014/11/12 02:24:50 UTC

Fix for `cordova emulate ios` to support iPhone 6

Hello,

I just started with Cordova and wanted to keep everything on the CLI so I can run the build and emulate cycle without having to open Xcode. In order to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to use ios-sim 3.x’s —devicetypeid syntax.

I have attached it here but I would like to contribute this back to the community as well. Is the only channel for submitting fixes through Jira or can I fork on GitHub and submit a pull request?

Thanks!

– Seth

Re: Fix for `cordova emulate ios` to support iPhone 6

Posted by Shazron <sh...@gmail.com>.

Here is the file history:
https://github.com/apache/cordova-ios/commits/master/bin/templates/scripts/cordova/run

Thank you however for contributing! I would encourage you to file pull
requests in the future. The repo itself has a CONTRIBUTING.md with
guidelines. Each pull request should be accompanied by a JIRA issue as well.

On Wed, Nov 12, 2014 at 7:23 AM, Shazron <sh...@gmail.com> wrote:

> Hi Seth,
> The run script does not exist in the cordova-cli, it exists in the
> cordova-ios repo, and I believe this issue has already been fixed in 3.7.0.
>
> On Tue, Nov 11, 2014 at 5:24 PM, Seth Voltz <se...@designgods.net> wrote:
>
>> Hello,
>>
>> I just started with Cordova and wanted to keep everything on the CLI so I
>> can run the build and emulate cycle without having to open Xcode. In order
>> to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to
>> use ios-sim 3.x’s —devicetypeid syntax.
>>
>> I have attached it here but I would like to contribute this back to the
>> community as well. Is the only channel for submitting fixes through Jira or
>> can I fork on GitHub and submit a pull request?
>>
>> Thanks!
>>
>> – Seth
>>
>>
>>
>>
>

Re: Fix for `cordova emulate ios` to support iPhone 6

Posted by Shazron <sh...@gmail.com>.

Hi Seth,
The run script does not exist in the cordova-cli, it exists in the
cordova-ios repo, and I believe this issue has already been fixed in 3.7.0.

On Tue, Nov 11, 2014 at 5:24 PM, Seth Voltz <se...@designgods.net> wrote:

> Hello,
>
> I just started with Cordova and wanted to keep everything on the CLI so I
> can run the build and emulate cycle without having to open Xcode. In order
> to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to
> use ios-sim 3.x’s —devicetypeid syntax.
>
> I have attached it here but I would like to contribute this back to the
> community as well. Is the only channel for submitting fixes through Jira or
> can I fork on GitHub and submit a pull request?
>
> Thanks!
>
> – Seth
>
>
>
>