You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by si...@apache.org on 2008/11/29 06:27:02 UTC
svn commit: r721640 - in /maven/components/trunk:
maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
maven-core/src/main/java/org/apache/maven/lifecycle/binding/LegacyLifecycleMappingParser.java
Author: sisbell
Date: Fri Nov 28 21:27:02 2008
New Revision: 721640
URL: http://svn.apache.org/viewvc?rev=721640&view=rev
Log:
Throw illegal argument, not NPE.
Modified:
maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/binding/LegacyLifecycleMappingParser.java
Modified: maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java?rev=721640&r1=721639&r2=721640&view=diff
==============================================================================
--- maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java (original)
+++ maven/components/trunk/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java Fri Nov 28 21:27:02 2008
@@ -749,7 +749,7 @@
id = repository.getId();
}
- getLogger().info( "Using mirror: " + mirror.getId() + " for repository: " + repository.getId() + "\n(mirror url: " + mirror.getUrl() + ")" );
+ getLogger().debug( "Using mirror: " + mirror.getId() + " for repository: " + repository.getId() + "\n(mirror url: " + mirror.getUrl() + ")" );
repository = repositoryFactory.createArtifactRepository( id, mirror.getUrl(),
repository.getLayout(), repository.getSnapshots(),
repository.getReleases() );
Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/binding/LegacyLifecycleMappingParser.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/binding/LegacyLifecycleMappingParser.java?rev=721640&r1=721639&r2=721640&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/binding/LegacyLifecycleMappingParser.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/binding/LegacyLifecycleMappingParser.java Fri Nov 28 21:27:02 2008
@@ -35,6 +35,11 @@
public LifecycleBindings parseDefaultMappings( final List lifecycles )
throws LifecycleSpecificationException
{
+ if( lifecycles == null )
+ {
+ throw new IllegalArgumentException("lifecycles: null");
+ }
+
LifecycleBindings bindings = new LifecycleBindings();
bindings.setPackaging( "unmatched" );