You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2026/05/05 18:34:35 UTC
[PR] Turn off ASAN leak detection running tscore/CompileParseRules during build [trafficserver]
cmcfarlen opened a new pull request, #13137:
URL: https://github.com/apache/trafficserver/pull/13137
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Turn off ASAN leak detection running tscore/CompileParseRules during build [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #13137:
URL: https://github.com/apache/trafficserver/pull/13137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Turn off ASAN leak detection running tscore/CompileParseRules during build [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13137:
URL: https://github.com/apache/trafficserver/pull/13137#issuecomment-4453033814
Cherry-picked to 10.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Turn off ASAN leak detection running tscore/CompileParseRules during build [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13137:
URL: https://github.com/apache/trafficserver/pull/13137#issuecomment-4424519371
[approve ci osx autest 0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Turn off ASAN leak detection running tscore/CompileParseRules during build [trafficserver]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13137:
URL: https://github.com/apache/trafficserver/pull/13137#discussion_r3222566706
##########
src/tscore/CMakeLists.txt:
##########
@@ -21,7 +21,7 @@ add_executable(CompileParseRules CompileParseRules.cc)
add_custom_command(
OUTPUT ParseRulesCType ParseRulesCTypeToUpper ParseRulesCTypeToLower
- COMMAND CompileParseRules
+ COMMAND ${CMAKE_COMMAND} -E env ASAN_OPTIONS=detect_leaks=0 $<TARGET_FILE:CompileParseRules>
Review Comment:
This overrides ASAN_OPTIONS for the CompileParseRules invocation, which can unintentionally drop any user-specified ASan settings (e.g., symbolize/abort_on_error/suppressions) during the build. Consider preserving an existing ASAN_OPTIONS value (e.g., by prefixing detect_leaks=0 to the current setting) so only leak detection is disabled without clobbering other options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Turn off ASAN leak detection running tscore/CompileParseRules during build [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #13137:
URL: https://github.com/apache/trafficserver/pull/13137#discussion_r3222575443
##########
src/tscore/CMakeLists.txt:
##########
@@ -21,7 +21,7 @@ add_executable(CompileParseRules CompileParseRules.cc)
add_custom_command(
OUTPUT ParseRulesCType ParseRulesCTypeToUpper ParseRulesCTypeToLower
- COMMAND CompileParseRules
+ COMMAND ${CMAKE_COMMAND} -E env ASAN_OPTIONS=detect_leaks=0 $<TARGET_FILE:CompileParseRules>
Review Comment:
Since this runs during the build, asan failures here are not helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org