You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/07/24 18:38:18 UTC
spark git commit: [SPARK-9305] Rename org.apache.spark.Row to Item.
Repository: spark
Updated Branches:
refs/heads/master 431ca39be -> c8d71a418
[SPARK-9305] Rename org.apache.spark.Row to Item.
It's a thing used in test cases, but named Row. Pretty annoying because everytime I search for Row, it shows up before the Spark SQL Row, which is what a developer wants most of the time.
Author: Reynold Xin <rx...@databricks.com>
Closes #7638 from rxin/remove-row and squashes the following commits:
aeda52d [Reynold Xin] [SPARK-9305] Rename org.apache.spark.Row to Item.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/c8d71a41
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/c8d71a41
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/c8d71a41
Branch: refs/heads/master
Commit: c8d71a4183dfc83ff257047857af0b6d66c6b90d
Parents: 431ca39
Author: Reynold Xin <rx...@databricks.com>
Authored: Fri Jul 24 09:38:13 2015 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Fri Jul 24 09:38:13 2015 -0700
----------------------------------------------------------------------
.../test/scala/org/apache/spark/PartitioningSuite.scala | 10 +++++-----
.../scala/org/apache/spark/sql/RandomDataGenerator.scala | 3 +--
2 files changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/c8d71a41/core/src/test/scala/org/apache/spark/PartitioningSuite.scala
----------------------------------------------------------------------
diff --git a/core/src/test/scala/org/apache/spark/PartitioningSuite.scala b/core/src/test/scala/org/apache/spark/PartitioningSuite.scala
index 3316f56..aa80287 100644
--- a/core/src/test/scala/org/apache/spark/PartitioningSuite.scala
+++ b/core/src/test/scala/org/apache/spark/PartitioningSuite.scala
@@ -91,13 +91,13 @@ class PartitioningSuite extends SparkFunSuite with SharedSparkContext with Priva
test("RangePartitioner for keys that are not Comparable (but with Ordering)") {
// Row does not extend Comparable, but has an implicit Ordering defined.
- implicit object RowOrdering extends Ordering[Row] {
- override def compare(x: Row, y: Row): Int = x.value - y.value
+ implicit object RowOrdering extends Ordering[Item] {
+ override def compare(x: Item, y: Item): Int = x.value - y.value
}
- val rdd = sc.parallelize(1 to 4500).map(x => (Row(x), Row(x)))
+ val rdd = sc.parallelize(1 to 4500).map(x => (Item(x), Item(x)))
val partitioner = new RangePartitioner(1500, rdd)
- partitioner.getPartition(Row(100))
+ partitioner.getPartition(Item(100))
}
test("RangPartitioner.sketch") {
@@ -252,4 +252,4 @@ class PartitioningSuite extends SparkFunSuite with SharedSparkContext with Priva
}
-private sealed case class Row(value: Int)
+private sealed case class Item(value: Int)
http://git-wip-us.apache.org/repos/asf/spark/blob/c8d71a41/sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
index b9f2ad7..75ae29d 100644
--- a/sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
+++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala
@@ -69,8 +69,7 @@ object RandomDataGenerator {
* Returns a function which generates random values for the given [[DataType]], or `None` if no
* random data generator is defined for that data type. The generated values will use an external
* representation of the data type; for example, the random generator for [[DateType]] will return
- * instances of [[java.sql.Date]] and the generator for [[StructType]] will return a
- * [[org.apache.spark.Row]].
+ * instances of [[java.sql.Date]] and the generator for [[StructType]] will return a [[Row]].
*
* @param dataType the type to generate values for
* @param nullable whether null values should be generated
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org