You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Andrei Shakirin (JIRA)" <ji...@apache.org> on 2012/05/06 11:56:59 UTC

[jira] [Created] (CXF-4289) Coping Request SOAP Headers to Fault response

Andrei Shakirin created CXF-4289:
------------------------------------

             Summary: Coping Request SOAP Headers to Fault response
                 Key: CXF-4289
                 URL: https://issues.apache.org/jira/browse/CXF-4289
             Project: CXF
          Issue Type: Improvement
            Reporter: Andrei Shakirin
            Priority: Minor
         Attachments: JAXWSMethodInvoker.patch

Hi,

Actually JAXWSMethodInvoker and AbstractJAXWSMethodInvoker contain code to copy request soap headers (except security one) to SOAP Fault: AbstractJAXWSMethodInvoker.updateHeader().

I see some use cases when it is not really desired:

1) Request SOAP headers contains some labelling information about request elements and they make sense only with request
2) Request SOAP headers extending request elements with meta-information

If request headers are copied into fault response, they can be invalid in response context and cause undesired effects:

a) it makes response processing on the client side more difficult, especially if processing interceptor is called before incoming fault message is recognized and placed into exchange.getInFaultMessage()
b) response fault message has larger size

Proposal is to define context property that give user the possibility to switch-off coping request headers into fault response.
Patch is attached.

Regards,
Andrei.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4289) Coping Request SOAP Headers to Fault response

Posted by "Andrei Shakirin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Shakirin updated CXF-4289:
---------------------------------

    Attachment: JAXWSMethodInvoker.patch
    
> Coping Request SOAP Headers to Fault response
> ---------------------------------------------
>
>                 Key: CXF-4289
>                 URL: https://issues.apache.org/jira/browse/CXF-4289
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Priority: Minor
>         Attachments: JAXWSMethodInvoker.patch
>
>
> Hi,
> Actually JAXWSMethodInvoker and AbstractJAXWSMethodInvoker contain code to copy request soap headers (except security one) to SOAP Fault: AbstractJAXWSMethodInvoker.updateHeader().
> I see some use cases when it is not really desired:
> 1) Request SOAP headers contains some labelling information about request elements and they make sense only with request
> 2) Request SOAP headers extending request elements with meta-information
> If request headers are copied into fault response, they can be invalid in response context and cause undesired effects:
> a) it makes response processing on the client side more difficult, especially if processing interceptor is called before incoming fault message is recognized and placed into exchange.getInFaultMessage()
> b) response fault message has larger size
> Proposal is to define context property that give user the possibility to switch-off coping request headers into fault response.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CXF-4289) Coping Request SOAP Headers to Fault response

Posted by "Ulhas Bhole (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277845#comment-13277845 ] 

Ulhas Bhole commented on CXF-4289:
----------------------------------

I will take a look into it and apply patch soon. 

Regards,

Ulhas Bhole
                
> Coping Request SOAP Headers to Fault response
> ---------------------------------------------
>
>                 Key: CXF-4289
>                 URL: https://issues.apache.org/jira/browse/CXF-4289
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Assignee: Ulhas Bhole
>            Priority: Minor
>         Attachments: JAXWSMethodInvoker.patch
>
>
> Hi,
> Actually JAXWSMethodInvoker and AbstractJAXWSMethodInvoker contain code to copy request soap headers (except security one) to SOAP Fault: AbstractJAXWSMethodInvoker.updateHeader().
> I see some use cases when it is not really desired:
> 1) Request SOAP headers contains some labelling information about request elements and they make sense only with request
> 2) Request SOAP headers extending request elements with meta-information
> If request headers are copied into fault response, they can be invalid in response context and cause undesired effects:
> a) it makes response processing on the client side more difficult, especially if processing interceptor is called before incoming fault message is recognized and placed into exchange.getInFaultMessage()
> b) response fault message has larger size
> Proposal is to define context property that give user the possibility to switch-off coping request headers into fault response.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CXF-4289) Coping Request SOAP Headers to Fault response

Posted by "Ulhas Bhole (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ulhas Bhole reassigned CXF-4289:
--------------------------------

    Assignee: Ulhas Bhole
    
> Coping Request SOAP Headers to Fault response
> ---------------------------------------------
>
>                 Key: CXF-4289
>                 URL: https://issues.apache.org/jira/browse/CXF-4289
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Andrei Shakirin
>            Assignee: Ulhas Bhole
>            Priority: Minor
>         Attachments: JAXWSMethodInvoker.patch
>
>
> Hi,
> Actually JAXWSMethodInvoker and AbstractJAXWSMethodInvoker contain code to copy request soap headers (except security one) to SOAP Fault: AbstractJAXWSMethodInvoker.updateHeader().
> I see some use cases when it is not really desired:
> 1) Request SOAP headers contains some labelling information about request elements and they make sense only with request
> 2) Request SOAP headers extending request elements with meta-information
> If request headers are copied into fault response, they can be invalid in response context and cause undesired effects:
> a) it makes response processing on the client side more difficult, especially if processing interceptor is called before incoming fault message is recognized and placed into exchange.getInFaultMessage()
> b) response fault message has larger size
> Proposal is to define context property that give user the possibility to switch-off coping request headers into fault response.
> Patch is attached.
> Regards,
> Andrei.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira