You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by th...@apache.org on 2020/02/21 22:24:01 UTC

[tapestry-5] branch master updated: Attempt to fix ZoneTests.css_insertion_point, failing in Jenkins

This is an automated email from the ASF dual-hosted git repository.

thiagohp pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tapestry-5.git


The following commit(s) were added to refs/heads/master by this push:
     new 4dd103e  Attempt to fix ZoneTests.css_insertion_point, failing in Jenkins
4dd103e is described below

commit 4dd103eb2e41277f1f8ea7aeb3bc3503a826bf82
Author: Thiago H. de Paula Figueiredo <th...@arsmachina.com.br>
AuthorDate: Fri Feb 21 19:22:47 2020 -0300

    Attempt to fix ZoneTests.css_insertion_point, failing in Jenkins
---
 .../java/org/apache/tapestry5/integration/app1/ZoneTests.java  | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
index 77acefe..9a975ff 100644
--- a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
@@ -275,6 +275,14 @@ public class ZoneTests extends App1TestCase
         }
 
     }
+    
+    private void assertCSSStartsWith(String elementId, String cssProperty, String expected)
+    {
+        String actual = selenium.getEval(String.format("window.document.defaultView.getComputedStyle(window.document.getElementById('%s'), null).getPropertyValue('%s')",
+                elementId, cssProperty));
+
+        assertTrue(actual.startsWith("underline"), String.format("CSS property '%s' of '%s' should start with '%s'.", cssProperty, elementId, expected));
+    }
 
     private void assertCSS(String elementId, String cssProperty, String expected)
     {
@@ -303,7 +311,7 @@ public class ZoneTests extends App1TestCase
         // zonedemo-viaajax.css; green from zonedmeo-overrides.css (not blue as defined in zonedemo-viaajax.css).
 
         assertCSS("demo-aip", "color", "rgb(0, 128, 0)");
-        assertCSS("demo-aip", "text-decoration", "underline");
+        assertCSSStartsWith("demo-aip", "text-decoration", "underline");
     }
 
     /**