You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/14 04:24:45 UTC

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12360: Fix the master CI broken with update dispatch rate block issue

gaoran10 commented on a change in pull request #12360:
URL: https://github.com/apache/pulsar/pull/12360#discussion_r728624503



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java
##########
@@ -161,15 +162,19 @@ private DispatchRate createDispatchRate() {
     public void updateDispatchRate() {
         Optional<DispatchRate> dispatchRate = getTopicPolicyDispatchRate(brokerService, topicName, type);
         if (!dispatchRate.isPresent()) {
-            dispatchRate = Optional.ofNullable(getPoliciesDispatchRate(brokerService));
+            getPoliciesDispatchRateAsync(brokerService).thenAccept(dispatchRateOp -> {

Review comment:
       Do we need to handle the exception situation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org