You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:36:09 UTC
[GitHub] [incubator-nuttx] cederom opened a new pull request #4673: Cederom add bsd support 20211016
cederom opened a new pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673
## Summary
Initial support draft that adds support for *BSD OS for configuration scripts. Needs verification! :-)
## Impact
* `tools/configure.sh`
* `tools/configure.c`
* `tools/sethost.sh`
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735655196
##########
File path: tools/configure.c
##########
@@ -166,7 +167,7 @@ static const char *g_optfiles[] =
static void show_usage(const char *progname, int exitcode)
{
- fprintf(stderr, "\nUSAGE: %s [-d] [-E] [-e] [-b|f] [-L] [-l|m|c|g|n] "
Review comment:
As you can see here @xiaoxiang781216 there is an existing mandatory switch `[-b|-f]` here in `tools/configure.c` so we cannot use `-b` for BSD host.. I have chosen `-B` instead :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735694490
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
USAGE="
-USAGE: ${0} [-E] [-e] [-l|m|c|g|n] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
+USAGE: ${0} [-E] [-e] [-l|m|c|g|n|B] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
Review comment:
Ok, it make reasonable now, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on pull request #4673: Cederom add bsd support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#issuecomment-944973903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735695009
##########
File path: tools/configure.c
##########
@@ -166,7 +167,7 @@ static const char *g_optfiles[] =
static void show_usage(const char *progname, int exitcode)
{
- fprintf(stderr, "\nUSAGE: %s [-d] [-E] [-e] [-b|f] [-L] [-l|m|c|g|n] "
Review comment:
I am fine with the change, @cederom please squash them, so we can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#issuecomment-951250428
Thank you guys for all your time, hints.. and patience !! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r730634818
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
USAGE="
-USAGE: ${0} [-E] [-e] [-l|m|c|g|n] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
+USAGE: ${0} [-E] [-e] [-l|m|c|g|n|B] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
Review comment:
should we use 'b' like other command?
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
Review comment:
MAKE_CMD->MAKECMD like TOPDIR?
##########
File path: tools/configure.c
##########
@@ -166,7 +167,7 @@ static const char *g_optfiles[] =
static void show_usage(const char *progname, int exitcode)
{
- fprintf(stderr, "\nUSAGE: %s [-d] [-E] [-e] [-b|f] [-L] [-l|m|c|g|n] "
Review comment:
ditto
##########
File path: tools/sethost.sh
##########
@@ -22,14 +22,15 @@ set -e
progname=$0
host=
wenv=
+MAKE_CMD="make"
Review comment:
same comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom edited a comment on pull request #4673: Cederom add bsd support 20211016
Posted by GitBox <gi...@apache.org>.
cederom edited a comment on pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#issuecomment-944973903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735677253
##########
File path: tools/configure.c
##########
@@ -166,7 +167,7 @@ static const char *g_optfiles[] =
static void show_usage(const char *progname, int exitcode)
{
- fprintf(stderr, "\nUSAGE: %s [-d] [-E] [-e] [-b|f] [-L] [-l|m|c|g|n] "
Review comment:
@cederom when you are done, please squash these commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735652440
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
Review comment:
fixed :-) commits pushed :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735652656
##########
File path: tools/sethost.sh
##########
@@ -22,14 +22,15 @@ set -e
progname=$0
host=
wenv=
+MAKE_CMD="make"
Review comment:
fixed :-) commits pushed :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on a change in pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r735645169
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
USAGE="
-USAGE: ${0} [-E] [-e] [-l|m|c|g|n] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
+USAGE: ${0} [-E] [-e] [-l|m|c|g|n|B] [L] [-a <app-dir>] <board-name>:<config-name> [make-opts]
Review comment:
Thank you @xiaoxiang781216 for your review :-) As explained in the commit message `-b` switch is already taken by `configure.c` program. In order to maintain coherence between all those configuration tools I chose `-B` for BSD family :-)
I also would prefer `-b` switch but then we would have to change also the `configure.c` part that would probably break backward compatibility..?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cederom commented on pull request #4673: CeDeROM add *BSD support 20211016
Posted by GitBox <gi...@apache.org>.
cederom commented on pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#issuecomment-951101136
Squashed :-) Thank you! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org