You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/25 04:17:09 UTC

Review Request: Moved checkpointing of forked PID into ExecutorLauncher and made process isolator exec mesos-launcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10114/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

Work in progress.


Diffs
-----

  configure.ac c3b5a0518e3ab1137a6353d359649abb491b46f3 
  include/mesos/executor.hpp 9b258347c79bf54a85cc64fc84ca7a433d8d847f 
  include/mesos/scheduler.hpp 1a7fcb9656a8f13d603cffeec9eb0f3c7aade05b 
  src/launcher/launcher.hpp a527dbc867a6471b0b92521dad5adffb486a5ce4 
  src/launcher/launcher.cpp eb8d6fb48c571ca10a7a057667b503e2723beef3 
  src/launcher/main.cpp c99ef72bdda4a4d39015ed775ac4b7e5c659eea6 
  src/python/src/mesos.py 546a07a4eabfb143ba871f31deda62f86e0cdfa6 
  src/slave/cgroups_isolator.hpp 1732c4e9ea44eb3b4d6234898f28bf3a02df4a7e 
  src/slave/cgroups_isolator.cpp ebc2843c57d5c1787394d0572aca1ead3e5734f1 
  src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 
  src/slave/process_isolator.hpp 920a667bb2ecc4c497ada39020579012110d9204 
  src/slave/process_isolator.cpp 210ea10ad97e08c7a303249da97e70b438dfe11d 
  src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
  src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 
  src/slave/state.hpp 1e3e894ee91d2b944d1d53642b5ebfcc52c02703 
  src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d 
  src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 
  src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a 
  src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 
  src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd 
  src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252 
  src/tests/utils.cpp 9d1d5ad1e192b0f44a7a7173839b292f6bedad15 
  third_party/libprocess/configure.ac cb7f0d73c6ddc1e75f7a3120858362c56a003aa7 
  third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7 
  third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4 
  third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
  third_party/libprocess/src/process.cpp 9eb1962222c81675f105142c496ed64575ed4636 
  third_party/libprocess/src/tests/io_tests.cpp 9115a968b81739c33afe98b673797ca472cc8b87 
  third_party/libprocess/third_party/stout/include/stout/os.hpp 5c217836a4a60402945544cba862b4c936ff0f83 

Diff: https://reviews.apache.org/r/10114/diff/


Testing
-------


Thanks,

Benjamin Hindman


Re: Review Request: Moved checkpointing of forked PID into ExecutorLauncher and made process isolator exec mesos-launcher.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10114/#review19716
-----------------------------------------------------------


Can you drop this now? I have committed this.


- Vinod Kone


On March 25, 2013, 3:17 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10114/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 3:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> Work in progress.
> 
> 
> Diffs
> -----
> 
>   configure.ac c3b5a0518e3ab1137a6353d359649abb491b46f3 
>   include/mesos/executor.hpp 9b258347c79bf54a85cc64fc84ca7a433d8d847f 
>   include/mesos/scheduler.hpp 1a7fcb9656a8f13d603cffeec9eb0f3c7aade05b 
>   src/launcher/launcher.hpp a527dbc867a6471b0b92521dad5adffb486a5ce4 
>   src/launcher/launcher.cpp eb8d6fb48c571ca10a7a057667b503e2723beef3 
>   src/launcher/main.cpp c99ef72bdda4a4d39015ed775ac4b7e5c659eea6 
>   src/python/src/mesos.py 546a07a4eabfb143ba871f31deda62f86e0cdfa6 
>   src/slave/cgroups_isolator.hpp 1732c4e9ea44eb3b4d6234898f28bf3a02df4a7e 
>   src/slave/cgroups_isolator.cpp ebc2843c57d5c1787394d0572aca1ead3e5734f1 
>   src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 
>   src/slave/process_isolator.hpp 920a667bb2ecc4c497ada39020579012110d9204 
>   src/slave/process_isolator.cpp 210ea10ad97e08c7a303249da97e70b438dfe11d 
>   src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
>   src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 
>   src/slave/state.hpp 1e3e894ee91d2b944d1d53642b5ebfcc52c02703 
>   src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d 
>   src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 
>   src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a 
>   src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 
>   src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd 
>   src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252 
>   src/tests/utils.cpp 9d1d5ad1e192b0f44a7a7173839b292f6bedad15 
>   third_party/libprocess/configure.ac cb7f0d73c6ddc1e75f7a3120858362c56a003aa7 
>   third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7 
>   third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4 
>   third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
>   third_party/libprocess/src/process.cpp 9eb1962222c81675f105142c496ed64575ed4636 
>   third_party/libprocess/src/tests/io_tests.cpp 9115a968b81739c33afe98b673797ca472cc8b87 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp 5c217836a4a60402945544cba862b4c936ff0f83 
> 
> Diff: https://reviews.apache.org/r/10114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Moved checkpointing of forked PID into ExecutorLauncher and made process isolator exec mesos-launcher.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10114/#review19717
-----------------------------------------------------------


Can you drop this now? I have committed this.


- Vinod Kone


On March 25, 2013, 3:17 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10114/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 3:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> Work in progress.
> 
> 
> Diffs
> -----
> 
>   configure.ac c3b5a0518e3ab1137a6353d359649abb491b46f3 
>   include/mesos/executor.hpp 9b258347c79bf54a85cc64fc84ca7a433d8d847f 
>   include/mesos/scheduler.hpp 1a7fcb9656a8f13d603cffeec9eb0f3c7aade05b 
>   src/launcher/launcher.hpp a527dbc867a6471b0b92521dad5adffb486a5ce4 
>   src/launcher/launcher.cpp eb8d6fb48c571ca10a7a057667b503e2723beef3 
>   src/launcher/main.cpp c99ef72bdda4a4d39015ed775ac4b7e5c659eea6 
>   src/python/src/mesos.py 546a07a4eabfb143ba871f31deda62f86e0cdfa6 
>   src/slave/cgroups_isolator.hpp 1732c4e9ea44eb3b4d6234898f28bf3a02df4a7e 
>   src/slave/cgroups_isolator.cpp ebc2843c57d5c1787394d0572aca1ead3e5734f1 
>   src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 
>   src/slave/process_isolator.hpp 920a667bb2ecc4c497ada39020579012110d9204 
>   src/slave/process_isolator.cpp 210ea10ad97e08c7a303249da97e70b438dfe11d 
>   src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
>   src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 
>   src/slave/state.hpp 1e3e894ee91d2b944d1d53642b5ebfcc52c02703 
>   src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d 
>   src/slave/status_update_manager.hpp e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 
>   src/slave/status_update_manager.cpp 044d245f370ef23ddc67fadbf7f8fe9d75dd662a 
>   src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab 
>   src/tests/slave_recovery_tests.cpp 47f9b0f215af2fb9bc300e0c92535b6f91afa5cd 
>   src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252 
>   src/tests/utils.cpp 9d1d5ad1e192b0f44a7a7173839b292f6bedad15 
>   third_party/libprocess/configure.ac cb7f0d73c6ddc1e75f7a3120858362c56a003aa7 
>   third_party/libprocess/include/process/future.hpp cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7 
>   third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4 
>   third_party/libprocess/include/process/timeout.hpp a907af19c9faa1c87864c5294a8e833bdca60252 
>   third_party/libprocess/src/process.cpp 9eb1962222c81675f105142c496ed64575ed4636 
>   third_party/libprocess/src/tests/io_tests.cpp 9115a968b81739c33afe98b673797ca472cc8b87 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp 5c217836a4a60402945544cba862b4c936ff0f83 
> 
> Diff: https://reviews.apache.org/r/10114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>