You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/05/23 11:54:00 UTC

[GitHub] [guacamole-server] necouchman commented on a change in pull request #275: GUACAMOLE-1059: Check array boundary for sound formats

necouchman commented on a change in pull request #275:
URL: https://github.com/apache/guacamole-server/pull/275#discussion_r429539347



##########
File path: src/protocols/rdp/channels/rdpsnd/rdpsnd-messages.c
##########
@@ -296,7 +296,7 @@ void guac_rdpsnd_wave_info_handler(guac_rdp_common_svc* svc,
     rdpsnd->next_pdu_is_wave = TRUE;
 
     /* Reset audio stream if format has changed */
-    if (audio != NULL)
+    if (audio != NULL && format < sizeof(rdpsnd->formats))

Review comment:
       Okay, took a stab at a log message - probably needs some tweaking, so let me know what needs to be changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org