[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3812: HIVE-26788: Update stats of table/partition after minor compaction us…

[GitBox <gi...@apache.org>]

SourabhBadhya commented on code in PR #3812:
URL: https://github.com/apache/hive/pull/3812#discussion_r1039378601


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/StatsUpdater.java:
##########
@@ -73,6 +69,9 @@ public void gatherStats(CompactionInfo ci, HiveConf conf, String userName, Strin
                 sb.append(")");
             }
             sb.append(" compute statistics");
+            if (ci.isMinorCompaction()) {
+                sb.append(" noscan");

Review Comment:
   Minor compaction is expected to not compact too many files and hence in most scenarios only the number of files gets changed after minor compaction. Whereas large updates like major compaction needs to update all statistics (since it happens once in a while) to keep the metadata updated. Therefore the idea was to do a fast update of statistics on a minor compaction & do complete update in case of major compaction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org