You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/08/28 08:25:40 UTC
[GitHub] [iceberg] kbendick opened a new issue #3045: Try to unify usage of Locale.ROOT and Locale.ENGLISH to just one
kbendick opened a new issue #3045:
URL: https://github.com/apache/iceberg/issues/3045
Looking through the current code in master for `Locale.*`, I found instances where we use `Locale.ROOT` and isntances where we use `Locale.English`.
Unless there's a pressing need to use one or the other depending on the situation, we should probably stick to just one consistently to avoid possible confusion or errors.
I could see non-English characters coming up in partition names in paths, for example. But off the top of my head, I can't think of a reason that Locale.ENGLISH would be needed and Locale.ROOT wouldn't suffice.
Locale.ENGLISH is the most common one, by far.
Count of instances of each
- Locale.English - 48
- Locale.ROOT - 25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #3045: Try to unify usage of Locale.ROOT and Locale.ENGLISH to just one
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #3045:
URL: https://github.com/apache/iceberg/issues/3045#issuecomment-907593431
Instances of Locale.ROOT
```
core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java
94: catalog.loadTable(TableIdentifier.parse(tableIdent + "." + type.name().toLowerCase(Locale.ROOT)));
116: TableIdentifier metadataIdent2 = TableIdentifier.parse(tableIdent + "." + type.name().toLowerCase(Locale.ROOT));
core/src/main/java/org/apache/iceberg/CachingCatalog.java
157: builder.add(TableIdentifier.parse(ident + "." + type.name().toLowerCase(Locale.ROOT)));
core/src/main/java/org/apache/iceberg/BaseFile.java
442: .add("content", content.toString().toLowerCase(Locale.ROOT))
core/src/main/java/org/apache/iceberg/SortOrderParser.java
75: return direction.toString().toLowerCase(Locale.ROOT);
134: return SortDirection.valueOf(directionAsString.toUpperCase(Locale.ROOT));
core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
156: this.format = FileFormat.valueOf(formatAsString.toUpperCase(Locale.ROOT));
core/src/main/java/org/apache/iceberg/MetadataTableType.java
37: return MetadataTableType.valueOf(name.toUpperCase(Locale.ROOT));
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveProcedures.scala
167: val normalizedName = param.name.toLowerCase(Locale.ROOT)
170: val normalizedName = param.name.toLowerCase(Locale.ROOT)
177: case a @ NamedArgument(name, _) => a.copy(name = name.toLowerCase(Locale.ROOT))
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala
112: val normalized = sqlText.toLowerCase(Locale.ROOT).trim().replaceAll("\\s+", " ")
api/src/main/java/org/apache/iceberg/types/Types.java
62: String lowerTypeString = typeString.toLowerCase(Locale.ROOT);
571: return lazyFieldsByLowerCaseName().get(name.toLowerCase(Locale.ROOT));
642: byLowerCaseNameBuilder.put(field.name().toLowerCase(Locale.ROOT), field);
api/src/main/java/org/apache/iceberg/types/TypeUtil.java
125: indexByLowerCaseName.put(name.toLowerCase(Locale.ROOT), integer));
api/src/main/java/org/apache/iceberg/Schema.java
318: Integer id = lazyLowerCaseNameToId().get(name.toLowerCase(Locale.ROOT));
444: id = lazyLowerCaseNameToId().get(name.toLowerCase(Locale.ROOT));
spark3/src/main/java/org/apache/iceberg/spark/procedures/SparkProcedures.java
38: Supplier<ProcedureBuilder> builderSupplier = BUILDERS.get(name.toLowerCase(Locale.ROOT));
spark3/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java
69: options.get("overwrite-mode").toLowerCase(Locale.ROOT) : null;
spark3/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java
219: "Cannot process %s snapshot: %s", op.toLowerCase(Locale.ROOT), snapshot.snapshotId());
spark3/src/main/java/org/apache/iceberg/spark/source/SparkMergeBuilder.java
71: return IsolationLevel.valueOf(isolationLevelAsString.toUpperCase(Locale.ROOT));
spark3/src/main/java/org/apache/iceberg/spark/actions/BaseTableCreationSparkAction.java
126: String sourceTableProvider = sourceCatalogTable.provider().get().toLowerCase(Locale.ROOT);
spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReadProjection.java
79: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ROOT));
spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java
111: String formatAsString = wrapped.getString(fileFormatPosition).toUpperCase(Locale.ROOT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #3045: Try to unify usage of Locale.ROOT and Locale.ENGLISH to just one
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #3045:
URL: https://github.com/apache/iceberg/issues/3045#issuecomment-907593330
Instances of Locale.ROOT
```
core/src/main/java/org/apache/iceberg/CatalogUtil.java
213: switch (catalogType.toLowerCase(Locale.ENGLISH)) {
core/src/main/java/org/apache/iceberg/DataFiles.java
211: this.format = FileFormat.valueOf(newFormat.toUpperCase(Locale.ENGLISH));
core/src/main/java/org/apache/iceberg/TableMetadataParser.java
61: return Codec.valueOf(codecName.toUpperCase(Locale.ENGLISH));
core/src/main/java/org/apache/iceberg/avro/Avro.java
226: return CodecName.valueOf(codecAsString.toUpperCase(Locale.ENGLISH)).get();
core/src/main/java/org/apache/iceberg/MetricsModes.java
50: Matcher truncateMatcher = TRUNCATE.matcher(mode.toLowerCase(Locale.ENGLISH));
core/src/main/java/org/apache/iceberg/FileMetadata.java
149: this.format = FileFormat.valueOf(newFormat.toUpperCase(Locale.ENGLISH));
mr/src/test/java/org/apache/iceberg/mr/TestIcebergInputFormats.java
135: this.fileFormat = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputFormat.java
75: TableProperties.DEFAULT_FILE_FORMAT, TableProperties.DEFAULT_FILE_FORMAT_DEFAULT).toUpperCase(Locale.ENGLISH));
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
359: parameters.put(TABLE_TYPE_PROP, ICEBERG_TABLE_TYPE_VALUE.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScan.java
88: this.fileFormat = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/sink/TestTaskWriters.java
79: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/sink/TestDeltaTaskWriter.java
74: this.format = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java
100: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java
91: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java
95: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java
106: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
flink/src/main/java/org/apache/iceberg/flink/source/RowDataRewriter.java
73: FileFormat format = FileFormat.valueOf(formatString.toUpperCase(Locale.ENGLISH));
flink/src/main/java/org/apache/iceberg/flink/sink/FlinkWriterFactory.java
160: this.dataFileFormat = FileFormat.valueOf(dataFileFormatName.toUpperCase(Locale.ENGLISH));
163: this.deleteFileFormat = FileFormat.valueOf(deleteFileFormatName.toUpperCase(Locale.ENGLISH));
flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
408: return FileFormat.valueOf(formatString.toUpperCase(Locale.ENGLISH));
flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
87: switch (catalogType.toLowerCase(Locale.ENGLISH)) {
api/src/main/java/org/apache/iceberg/types/CheckCompatibility.java
259: currentType.typeId().toString().toLowerCase(Locale.ENGLISH), readPrimitive));
api/src/main/java/org/apache/iceberg/DistributionMode.java
53: return DistributionMode.valueOf(modeName.toUpperCase(Locale.ENGLISH));
api/src/main/java/org/apache/iceberg/transforms/Transforms.java
62: return Timestamps.valueOf(transform.toUpperCase(Locale.ENGLISH));
64: return Dates.valueOf(transform.toUpperCase(Locale.ENGLISH));
aws/src/integration/java/org/apache/iceberg/aws/glue/GlueCatalogTableTest.java
67: Assert.assertEquals(BaseMetastoreTableOperations.ICEBERG_TABLE_TYPE_VALUE.toUpperCase(Locale.ENGLISH),
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
172: properties.put(TABLE_TYPE_PROP, ICEBERG_TABLE_TYPE_VALUE.toUpperCase(Locale.ENGLISH));
aws/src/main/java/org/apache/iceberg/aws/s3/S3RequestUtil.java
77: switch (awsProperties.s3FileIoSseType().toLowerCase(Locale.ENGLISH)) {
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
160: properties.put(TABLE_TYPE_PROP, ICEBERG_TABLE_TYPE_VALUE.toUpperCase(Locale.ENGLISH));
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
345: return CompressionCodecName.valueOf(codecAsString.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/io/TestAppenderFactory.java
78: this.format = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/io/TestBaseTaskWriter.java
67: this.format = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/TestSplitScan.java
72: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java
80: this.format = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/io/TestGenericSortedPosDeleteWriter.java
71: this.format = FileFormat.valueOf(fileFormat.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
101: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
91: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java
266: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
spark3/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
182: FileFormat fileFormat = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
spark3/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java
168: return FileFormat.valueOf(formatString.toUpperCase(Locale.ENGLISH));
spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java
89: this.format = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
spark/src/test/java/org/apache/iceberg/spark/source/TestTimestampWithoutZone.java
125: FileFormat fileFormat = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
spark/src/main/java/org/apache/iceberg/spark/source/SparkWriterFactory.java
161: this.dataFileFormat = FileFormat.valueOf(dataFileFormatName.toUpperCase(Locale.ENGLISH));
164: this.deleteFileFormat = FileFormat.valueOf(deleteFileFormatName.toUpperCase(Locale.ENGLISH));
spark/src/main/java/org/apache/iceberg/spark/source/RowDataRewriter.java
66: this.format = FileFormat.valueOf(formatString.toUpperCase(Locale.ENGLISH));
spark2/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
184: FileFormat fileFormat = FileFormat.valueOf(format.toUpperCase(Locale.ENGLISH));
spark2/src/main/java/org/apache/iceberg/spark/source/Writer.java
127: return FileFormat.valueOf(formatString.toUpperCase(Locale.ENGLISH));
spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
149: fsscheme = fs.getScheme().toLowerCase(Locale.ENGLISH);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org