You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/03/08 08:32:47 UTC
[I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
kou opened a new issue, #40417:
URL: https://github.com/apache/arrow/issues/40417
### Describe the enhancement requested
We use `archery lint ...` to run linters. It's convenient because we don't need to know linters details but we need to install `archery[lint]` and we need to write Python code to add a new linter. They're a bit annoying.
How about using pre-commit https://pre-commit.com/ for all linters? If we use pre-commit:
* We don't need to write Python code for new linter and changing linter behavior (We need to write YAML instead)
* C++: We don't need to install `clang-format-14` separately (pre-commit can do it automatically)
* C++: We don't need to run CMake to run `clang-format-14`
Note that we already have some pre-commit configuration: https://github.com/apache/arrow/blob/main/.pre-commit-config.yaml
### Component(s)
Developer Tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on issue #40417:
URL: https://github.com/apache/arrow/issues/40417#issuecomment-2024149301
+1 this is a great initiative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40417:
URL: https://github.com/apache/arrow/issues/40417#issuecomment-2933476894
Done.
Removed IWYU and clang-tidy from subissues because they aren't used with "archery lint" for now.
We can revisit them when we want to use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40417:
URL: https://github.com/apache/arrow/issues/40417#issuecomment-2900219094
I've created subissues for remaining lints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #40417:
URL: https://github.com/apache/arrow/issues/40417#issuecomment-2475211992
Yes.
We can close this by removing `archery lint` related codes.
We need to list missing lists in `.pre-commit-config.yaml` as the next step.
See also: https://github.com/apache/arrow/blob/d7bc3788ea2773399b7ef489438c725999bfa83d/dev/archery/archery/utils/lint.py#L484-L535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #40417:
URL: https://github.com/apache/arrow/issues/40417#issuecomment-2001986305
+1 for pre-commit, which is at least reasonably common across projects these days IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #40417:
URL: https://github.com/apache/arrow/issues/40417#issuecomment-2474172768
Do you we still need to keep this issue open @kou, or is everything done here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #40417: [Dev] Use pre-commit-hook instead of "archery lint" for all lints
URL: https://github.com/apache/arrow/issues/40417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org