[GitHub] [dubbo-go] zouyx commented on a change in pull request #1188: Fix 3.0 ci problem

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #1188:
URL: https://github.com/apache/dubbo-go/pull/1188#discussion_r626606951



##########
File path: cluster/cluster_impl/failback_cluster_invoker.go
##########
@@ -169,7 +169,7 @@ func (invoker *failbackClusterInvoker) Invoke(ctx context.Context, invocation pr
 		logger.Errorf("Failback to invoke the method %v in the service %v, wait for retry in background. Ignored exception: %v.\n",
 			methodName, url.Service(), result.Error().Error())
 		// ignore
-		return &protocol.RPCResult{Err: result.Error()}
+		return &protocol.RPCResult{}

Review comment:
       why delete this err?

##########
File path: go.mod
##########
@@ -51,6 +50,7 @@ require (
 	github.com/stretchr/objx v0.2.0 // indirect
 	github.com/stretchr/testify v1.7.0
 	github.com/zouyx/agollo/v3 v3.4.5
+	go.etcd.io/etcd v0.0.0-20200402134248-51bdeb39e698

Review comment:
       suggest use version+incompatible, like v3.3.25+incompatible




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org