You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "olamy (via GitHub)" <gi...@apache.org> on 2023/02/13 03:33:57 UTC

[GitHub] [maven-surefire] olamy opened a new pull request, #614: [SUREFIRE-2150] upgrade to parent pom 39

olamy opened a new pull request, #614:
URL: https://github.com/apache/maven-surefire/pull/614

   Signed-off-by: Olivier Lamy <ol...@apache.org>
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] olamy merged pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #614:
URL: https://github.com/apache/maven-surefire/pull/614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] slawekjaranowski commented on pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #614:
URL: https://github.com/apache/maven-surefire/pull/614#issuecomment-1445056927

   I will wait for you - sorry for mess.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] olamy commented on pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #614:
URL: https://github.com/apache/maven-surefire/pull/614#issuecomment-1427592175

   yup sorry I didn't create this as a draft but it's still WIP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] slawekjaranowski commented on pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #614:
URL: https://github.com/apache/maven-surefire/pull/614#issuecomment-1445040331

   @olamy - I can finish it, do you want to work on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] slawekjaranowski commented on pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #614:
URL: https://github.com/apache/maven-surefire/pull/614#issuecomment-1445042739

   I'm starting work on SUREFIRE-2154, so I want to avoid feature merge conflicts I will do it.
   Have a rest on beach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] olamy commented on pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #614:
URL: https://github.com/apache/maven-surefire/pull/614#issuecomment-1445041553

   Oh yes I can finish that. I was on it this morning but had to go to the beach. I will resume work tomorrow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-surefire] olamy commented on pull request #614: [SUREFIRE-2150] upgrade to parent pom 39

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #614:
URL: https://github.com/apache/maven-surefire/pull/614#issuecomment-1445045325

   I have stuff already done locally!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org