You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/01 00:02:04 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

mjsax commented on a change in pull request #9660:
URL: https://github.com/apache/kafka/pull/9660#discussion_r532983342



##########
File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -254,6 +265,19 @@ public TopologyTestDriver(final Topology topology,
         this(topology, config, null);
     }
 
+    /**
+     * Create a new test diver instance.
+     * Initialized the internally mocked wall-clock time with {@link System#currentTimeMillis() current system time}.

Review comment:
       This overload takes `initialWallClockTimeMs`, thus this sentence seems to be incorrect? Should go to `TopologyTestDriver(final Topology topology)` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org