You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/23 22:21:16 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options

TheNeuralBit commented on a change in pull request #10529: [BEAM-9044] Protobuf options to Schema options
URL: https://github.com/apache/beam/pull/10529#discussion_r396791822
 
 

 ##########
 File path: sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java
 ##########
 @@ -205,10 +205,12 @@ static Schema getSchema(Descriptors.Descriptor descriptor) {
         // Store proto field number in metadata.
         FieldType fieldType =
             withMetaData(beamFieldTypeFromProtoField(fieldDescriptor), fieldDescriptor);
 
 Review comment:
   I think Reuven was referring to the metadata that's added in `withMetaData`, since that's the "special" proto metadata

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services