You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/03/24 20:47:37 UTC
Review Request 32452: Disallowed multiple cgroups base hierarchies in
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32452/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Ian Downes.
Repository: mesos
Description
-------
Disallowed multiple cgroups base hierarchies in tests.
Right now, if some subsystems are pre-mounted at /sys/fs/cgroup and some of them are not pre-mounted, the cgroups test will fail depending on the order in which the susbsystems we checked.
For instance, if the first subsystem we check is not pre-mounted, we will set the base hierarchy to TEST_CGROUPS_HIERARCHY. ANd we'll assume all subsystems are under TEST_CGROUPS_HIERARCHY, which might not be true.
This patch disallows the case where multiple base hierarchies exist.
Diffs
-----
src/tests/mesos.cpp 11e88330dd50913ab00da79054225d113541e83e
Diff: https://reviews.apache.org/r/32452/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 32452: Disallowed multiple cgroups base
hierarchies in tests.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32452/#review77630
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On March 24, 2015, 12:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32452/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 12:47 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallowed multiple cgroups base hierarchies in tests.
>
> Right now, if some subsystems are pre-mounted at /sys/fs/cgroup and some of them are not pre-mounted, the cgroups test will fail depending on the order in which the susbsystems we checked.
>
> For instance, if the first subsystem we check is not pre-mounted, we will set the base hierarchy to TEST_CGROUPS_HIERARCHY. ANd we'll assume all subsystems are under TEST_CGROUPS_HIERARCHY, which might not be true.
>
> This patch disallows the case where multiple base hierarchies exist.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 11e88330dd50913ab00da79054225d113541e83e
>
> Diff: https://reviews.apache.org/r/32452/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32452: Disallowed multiple cgroups base
hierarchies in tests.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32452/#review77650
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32452]
All tests passed.
- Mesos ReviewBot
On March 24, 2015, 7:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32452/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 7:47 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallowed multiple cgroups base hierarchies in tests.
>
> Right now, if some subsystems are pre-mounted at /sys/fs/cgroup and some of them are not pre-mounted, the cgroups test will fail depending on the order in which the susbsystems we checked.
>
> For instance, if the first subsystem we check is not pre-mounted, we will set the base hierarchy to TEST_CGROUPS_HIERARCHY. ANd we'll assume all subsystems are under TEST_CGROUPS_HIERARCHY, which might not be true.
>
> This patch disallows the case where multiple base hierarchies exist.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 11e88330dd50913ab00da79054225d113541e83e
>
> Diff: https://reviews.apache.org/r/32452/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32452: Disallowed multiple cgroups base
hierarchies in tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32452/#review77627
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 24, 2015, 7:47 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32452/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 7:47 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Disallowed multiple cgroups base hierarchies in tests.
>
> Right now, if some subsystems are pre-mounted at /sys/fs/cgroup and some of them are not pre-mounted, the cgroups test will fail depending on the order in which the susbsystems we checked.
>
> For instance, if the first subsystem we check is not pre-mounted, we will set the base hierarchy to TEST_CGROUPS_HIERARCHY. ANd we'll assume all subsystems are under TEST_CGROUPS_HIERARCHY, which might not be true.
>
> This patch disallows the case where multiple base hierarchies exist.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 11e88330dd50913ab00da79054225d113541e83e
>
> Diff: https://reviews.apache.org/r/32452/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>