You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Yakov Markovitch (JIRA)" <ji...@apache.org> on 2011/06/03 17:15:48 UTC
[jira] [Created] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Assertion/abort when starting TS with SOCKS proxy enabled
---------------------------------------------------------
Key: TS-818
URL: https://issues.apache.org/jira/browse/TS-818
Project: Traffic Server
Issue Type: Bug
Components: Core
Affects Versions: 2.1.8, 2.1.9
Environment: Linux x86-64
Reporter: Yakov Markovitch
When attempting to start TS with
CONFIG proxy.config.socks.socks_needed INT 1
CONFIG proxy.config.socks.socks_version INT 5
TS aborts at startup with the following message:
FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yakov Markovitch updated TS-818:
--------------------------------
Attachment: trafficserver.2.1.8.socks-reg-stat.patch
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045541#comment-13045541 ]
Bryan Call commented on TS-818:
-------------------------------
Reviews changes. I didn't seen anywhere in the code that these stats are incremented or decremented.
I do see these other stats being used:
proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_http_connections_stat);
proxy/SocksProxy.cc: SOCKSPROXY_INC_STAT(socksproxy_tunneled_connections_stat);
Looks like there needs to be some cleanup work with the socks stats. I think this is a good change to do for now, being that the release of 3.0.0 is coming...
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.1.0, 3.0.0
>
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-818:
-----------------------------
Fix Version/s: (was: 3.0.0)
Removing the 3.0.0 fix version, until the votes on the 3.0.0 backport has passed.
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.1.0
>
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-818:
-----------------------------
Fix Version/s: 3.1.0
Assignee: Leif Hedstrom
Thanks Yakov!
Do you think we should consider this fix for v3.0.0? It seems very safe, and straight forward, and we have time for simple fixes like this I think. But would like your input.
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.1.0
>
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-818:
-----------------------------
Backport to Version: 3.0.0
Fix Version/s: 3.0.0
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.1.0, 3.0.0
>
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-818:
-----------------------------
Backport to Version: (was: 3.0.0)
Fix Version/s: 3.0.0
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.1.0, 3.0.0
>
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043923#comment-13043923 ]
Yakov Markovitch commented on TS-818:
-------------------------------------
Yes I think it would be great. Will allow to remove an actual showstopper for SOCKS proxy usage (aside from this bug SOCKS proxy works rather well, at least so far).
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.1.0
>
> Attachments: trafficserver.2.1.8.socks-reg-stat.patch
>
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-818) Assertion/abort when starting TS with
SOCKS proxy enabled
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043392#comment-13043392 ]
Yakov Markovitch commented on TS-818:
-------------------------------------
The cause of the bug is in an attempt of duplicate registration in loadSocksConfiguration() (Socks.cc) of statistics counters proxy.process.socks.connections_successful, proxy.process.socks.connections_unsuccessful, and proxy.process.socks.connections_currently_open. To the moment of loadSocksConfiguration() call these counters are already registered by register_net_stats() (Net.cc), which is called from ink_net_init().
I've attached a small patch that fixes the bug.
> Assertion/abort when starting TS with SOCKS proxy enabled
> ---------------------------------------------------------
>
> Key: TS-818
> URL: https://issues.apache.org/jira/browse/TS-818
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.9, 2.1.8
> Environment: Linux x86-64
> Reporter: Yakov Markovitch
>
> When attempting to start TS with
> CONFIG proxy.config.socks.socks_needed INT 1
> CONFIG proxy.config.socks.socks_version INT 5
> TS aborts at startup with the following message:
> FATAL: RecProcess.cc:738: failed assert `false`
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira