[GitHub] [arrow] rtpsw commented on a diff in pull request #35513: GH-35506: [C++] Support First and Last aggregators in Substrait

["rtpsw (via GitHub)" <gi...@apache.org>]

rtpsw commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1189111602


##########
cpp/src/arrow/engine/substrait/serde.cc:
##########
@@ -236,14 +236,13 @@ ARROW_ENGINE_EXPORT Result<PlanInfo> DeserializePlan(
 
 namespace {
 
-Result<std::shared_ptr<acero::ExecPlan>> MakeSingleDeclarationPlan(
-    std::vector<acero::Declaration> declarations) {
+Status MakeSingleDeclarationPlan(acero::ExecPlan* plan,

Review Comment:
   Done. It turned out not easy to use `DeclarationToTable` here because of the extra setup needed for linking the input table and the consumer, but I did separate out the deserialization and obtained simpler code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org