You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by jiny2 <gi...@git.apache.org> on 2015/11/25 22:41:26 UTC
[GitHub] incubator-hawq pull request: HAWQ-194. Test facility for pausing g...
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/135
HAWQ-194. Test facility for pausing global resource manager container…
The external new test command is :
postgres=# select * from pg_play_resource_action('/Users/yjin/testquota2.txt','/Users/yjin/testquota2.out') t ( conn text, actname text, actfull text, result text, message text);
conn | actname | actfull | result | message
-------------------------------------------------
conn1 | quotapause | quotapause$pause$1 | 0 |
conn1 | wait | wait$/tmp/act | 0 |
conn1 | quotapause | quotapause$resume$1 | 0 |
onn1$quotapause$pause$0
conn1$wait$/tmp/act
conn1$quotapause$resume$0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiny2/incubator-hawq HAWQ-194
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 8471847f1c6d27d6f7eccdb5c00c1b655dfc7543
Author: Yi Jin <yj...@pivotal.io>
Date: 2015-11-25T21:40:18Z
HAWQ-194. Test facility for pausing global resource manager container lifecycle in resource pool
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-194. Test facility for pausing g...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/135#discussion_r45939441
--- Diff: src/backend/resourcemanager/include/resourcepool.h ---
@@ -311,6 +311,16 @@ uint32_t getSegResourceCapacityMemory(SegResource segres);
uint32_t getSegResourceCapacityCore(SegResource segres);
int getSegmentGRMContainerSize(SegResource segres);
+
+enum ResourcePoolQuotaControlFlags
+{
--- End diff --
How about use below flags:
QUOTA_PHASE_BEGIN = 0;
QUOTA_PHASE_TOACC_TO_ACCED,
QUOTA_PHASE_ACCED_TO_RESPOOL,
QUOTA_PHASE_TOKICK_TO_KICKED,
QUOTA_PHASE_KICKED_TO_RETURN,
QUOTA_PHASE_END
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-194. Test facility for pausing g...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/135#issuecomment-159785018
The improvement regarding testability for resource manager looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-194. Test facility for pausing g...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/135#issuecomment-159786752
Fixed comments. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-194. Test facility for pausing g...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---