You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/11/19 11:53:46 UTC

[GitHub] [pinot] Jackie-Jiang commented on pull request #9751: Fix NPE when reading ZK address from controller config

Jackie-Jiang commented on PR #9751:
URL: https://github.com/apache/pinot/pull/9751#issuecomment-1320868626

   > Nit: are we able to cover this in unit test if possible?
   
   The change in this PR basically change the NPE to a more readable error message, and IMO it is a little bit overkilling to add a test for it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org