[GitHub] [ozone] jojochuang commented on a diff in pull request #5259: HDDS-9255. LeaseRecovery CLI Should work for O3fs path.

["jojochuang (via GitHub)" <gi...@apache.org>]

jojochuang commented on code in PR #5259:
URL: https://github.com/apache/ozone/pull/5259#discussion_r1321827573


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/LeaseRecoverer.java:
##########
@@ -74,6 +75,8 @@ public Void call() throws Exception {
     FileSystem fs = FileSystem.get(uri, configuration);
     if (fs instanceof RootedOzoneFileSystem) {
       ((RootedOzoneFileSystem) fs).recoverLease(new Path(uri));
+    } else if (fs instanceof OzoneFileSystem) {
+      ((OzoneFileSystem) fs).recoverLease(new Path(uri));

Review Comment:
   In fact, we can now simplify it with 
   ```suggestion
       if (fs instanceof LeaseRecoverable) {
         ((LeaseRecoverable) fs).recoverLease(new Path(uri));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org