You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dg4prez <gi...@git.apache.org> on 2017/04/06 19:07:58 UTC
[GitHub] incubator-trafficcontrol pull request #438: Scope api changes
GitHub user dg4prez opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/438
Scope api changes
Configfiles API changes required to move the scope for remap.config, facts, records.config, and header rewrite files for greater cache-ability. Also modifies the configFiles from a hash to an array of hashes, improves the name scheme of variables and changes case scheme to camelCase from snake_case. HOSTNAME, HOSTNAME_FULL, __SERVER_TCP_PORT, and __CACHE_IPV4 are no longer replaced when generating the files, and must be replaced by ORT.
This PR requires https://github.com/apache/incubator-trafficcontrol/pull/437 to be merged at the same time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dg4prez/incubator-trafficcontrol scope_api_changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
----
commit 97da71cb613143c6d2cd5af6c4b6cbd94cddbb74
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-04-06T16:35:27Z
changes scope for facts, records.config, and header rewrite
commit 740a00531c9d7a22c1b90987a385c315b567f583
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-04-06T16:58:08Z
changes scope for remap.config
commit 37476e17a9b8043e7f9fe46230cea176c5ff58e7
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-04-06T17:26:56Z
modifies name to fname on disk and fixes rev proxy url lookup
commit eb1f97dda6f3cf8c717c65506a082cedeb0df9ff
Author: Derek Gelinas <de...@cable.comcast.com>
Date: 2017-04-06T18:54:19Z
fix hostname reference in profile parameter lookups
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #438: Scope api changes - requires PR ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---