You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Jeff Lubetkin (JIRA)" <ta...@jakarta.apache.org> on 2005/11/08 19:25:20 UTC

[jira] Created: (TAPESTRY-741) PopupLinkRenderer overrides wrong method of DefaultLinkRenderer

PopupLinkRenderer overrides wrong method of DefaultLinkRenderer
---------------------------------------------------------------

         Key: TAPESTRY-741
         URL: http://issues.apache.org/jira/browse/TAPESTRY-741
     Project: Tapestry
        Type: Bug
  Components: Contrib  
    Versions: 4.0    
 Environment: Tapestry 4.0-beta-12
    Reporter: Jeff Lubetkin


In his fix for TAPESTRY-580, HLS changed the signature of DefaultLinkRenderer.constructURL from constructURL(ILink, String, IRequestCycle) to constructURL(ILinkComponent, IRequestCycle).  PopupLinkRenderer's constructURL method was not modified to match the change, and is therefore not being called.

Too bad Tapestry's codebase can't use Java 1.5...this is the perfect example of why the "@Override" annotation is a good thing :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Assigned: (TAPESTRY-741) PopupLinkRenderer overrides wrong method of DefaultLinkRenderer

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-741?page=all ]

Howard M. Lewis Ship reassigned TAPESTRY-741:
---------------------------------------------

    Assign To: Howard M. Lewis Ship

> PopupLinkRenderer overrides wrong method of DefaultLinkRenderer
> ---------------------------------------------------------------
>
>          Key: TAPESTRY-741
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-741
>      Project: Tapestry
>         Type: Bug
>   Components: Contrib
>     Versions: 4.0
>  Environment: Tapestry 4.0-beta-12
>     Reporter: Jeff Lubetkin
>     Assignee: Howard M. Lewis Ship

>
> In his fix for TAPESTRY-580, HLS changed the signature of DefaultLinkRenderer.constructURL from constructURL(ILink, String, IRequestCycle) to constructURL(ILinkComponent, IRequestCycle).  PopupLinkRenderer's constructURL method was not modified to match the change, and is therefore not being called.
> Too bad Tapestry's codebase can't use Java 1.5...this is the perfect example of why the "@Override" annotation is a good thing :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


[jira] Closed: (TAPESTRY-741) PopupLinkRenderer overrides wrong method of DefaultLinkRenderer

Posted by "Howard M. Lewis Ship (JIRA)" <ta...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/TAPESTRY-741?page=all ]
     
Howard M. Lewis Ship closed TAPESTRY-741:
-----------------------------------------

    Fix Version: 4.0
     Resolution: Fixed

> PopupLinkRenderer overrides wrong method of DefaultLinkRenderer
> ---------------------------------------------------------------
>
>          Key: TAPESTRY-741
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-741
>      Project: Tapestry
>         Type: Bug
>   Components: Contrib
>     Versions: 4.0
>  Environment: Tapestry 4.0-beta-12
>     Reporter: Jeff Lubetkin
>     Assignee: Howard M. Lewis Ship
>      Fix For: 4.0

>
> In his fix for TAPESTRY-580, HLS changed the signature of DefaultLinkRenderer.constructURL from constructURL(ILink, String, IRequestCycle) to constructURL(ILinkComponent, IRequestCycle).  PopupLinkRenderer's constructURL method was not modified to match the change, and is therefore not being called.
> Too bad Tapestry's codebase can't use Java 1.5...this is the perfect example of why the "@Override" annotation is a good thing :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org